Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: gm/lightingshader.cpp

Issue 1265983003: Address some SkLightingShader TODOs (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Fix type Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | include/effects/SkPoint3.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/lightingshader.cpp
diff --git a/gm/lightingshader.cpp b/gm/lightingshader.cpp
index ad8823d27d68d69c08c256c7c01e929e82d10509..687968abb68663d7a95085bc9b79473db4d0ddcf 100644
--- a/gm/lightingshader.cpp
+++ b/gm/lightingshader.cpp
@@ -105,12 +105,12 @@ public:
LightingShaderGM() {
this->setBGColor(sk_tool_utils::color_to_565(0xFFCCCCCC));
- fLight.fColor = SkColorSetRGB(0xff, 0xff, 0xff);
+ fLight.fColor = SkColor3f::Make(1.0f, 1.0f, 1.0f);
fLight.fDirection.fX = 0.0f;
fLight.fDirection.fY = 0.0f;
fLight.fDirection.fZ = 1.0f;
- fAmbient = SkColorSetRGB(0x1f, 0x1f, 0x1f);
+ fAmbient = SkColor3f::Make(0.1f, 0.1f, 0.1f);
}
protected:
@@ -171,7 +171,7 @@ private:
SkBitmap fFrustumNormalMap;
SkLightingShader::Light fLight;
- SkColor fAmbient;
+ SkColor3f fAmbient;
typedef GM INHERITED;
};
« no previous file with comments | « no previous file | include/effects/SkPoint3.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698