include/effects/SkPoint3.h - Issue 1265983003: Address some SkLightingShader TODOs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: include/effects/SkPoint3.h

Issue 1265983003: Address some SkLightingShader TODOs (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fix type Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 /*	1 /*

2 * Copyright 2015 Google Inc.	2 * Copyright 2015 Google Inc.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license that can be	4 * Use of this source code is governed by a BSD-style license that can be

5 * found in the LICENSE file.	5 * found in the LICENSE file.

6 */	6 */

7	7

8 #ifndef SkPoint3_DEFINED	8 #ifndef SkPoint3_DEFINED

9 #define SkPoint3_DEFINED	9 #define SkPoint3_DEFINED

10	10

(...skipping 91 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
102 static SkScalar DotProduct(const SkPoint3& a, const SkPoint3& b) {	102 static SkScalar DotProduct(const SkPoint3& a, const SkPoint3& b) {

103 return a.fX * b.fX + a.fY * b.fY + a.fZ * b.fZ;	103 return a.fX * b.fX + a.fY * b.fY + a.fZ * b.fZ;

104 }	104 }

105	105

106 SkScalar dot(const SkPoint3& vec) const {	106 SkScalar dot(const SkPoint3& vec) const {

107 return DotProduct(*this, vec);	107 return DotProduct(*this, vec);

108 }	108 }

109 };	109 };

110	110

111 typedef SkPoint3 SkVector3;	111 typedef SkPoint3 SkVector3;

	112 typedef SkPoint3 SkColor3f;

112	113

113 #endif	114 #endif

OLD	NEW

« no previous file with comments | « gm/lightingshader.cpp ('k') | samplecode/SampleLighting.cpp » ('j') | no next file with comments »