Issue 1265853003: CSSValue Immediates: Immediates from all CSSPrimitiveValue constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1265853003: CSSValue Immediates: Immediates from all CSSPrimitiveValue constructors (Closed)

Created:
5 years, 4 months ago by sashab

Modified:
5 years, 4 months ago

Reviewers:

CC:
blink-reviews, shans, rjwright, blink-reviews-style_chromium.org, blink-reviews-animation_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, groby+blinkspell_chromium.org, darktears, rwlbuis, Eric Willigers

Base URL:
https://chromium.googlesource.com/chromium/blink.git@tagged_ptrs_base

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

CSSValue Immediates: Immediates from all CSSPrimitiveValue constructors Update CSSPrimitiveValue's platform value constructors to also create tagged pointers, where possible. Depends on crrev.com/1252683002. This is part of a larger refactor of CSSValue to introduce immediates, discussed on the bug. BUG=486252 COMMIT=false

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+982 lines, -984 lines)			Patch
M	Source/core/animation/ColorStyleInterpolationTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/animation/DoubleStyleInterpolation.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/animation/DoubleStyleInterpolationTest.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/animation/ListStyleInterpolationTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/animation/SVGStrokeDasharrayStyleInterpolationTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/animation/ShadowStyleInterpolation.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/animation/ShadowStyleInterpolationTest.cpp	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/core/animation/VisibilityStyleInterpolation.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/animation/VisibilityStyleInterpolationTest.cpp	View	1 chunk	+5 lines, -5 lines	0 comments	Download
M	Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/animation/css/CSSAnimatableValueFactory.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/css/CSSPrimitiveValue.h	View	4 chunks	+15 lines, -5 lines	0 comments	Download
M	Source/core/css/CSSPrimitiveValueMappings.h	View	101 chunks	+913 lines, -925 lines	0 comments	Download
M	Source/core/css/CSSValuePool.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/css/ComputedStyleCSSValueMapping.cpp	View	8 chunks	+14 lines, -14 lines	0 comments	Download
M	Source/core/css/parser/CSSPropertyParser.cpp	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/core/editing/EditingStyle.cpp	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	Source/core/editing/EditorCommand.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Depends on Patchset:

Issue 1252683002 Patch 80008