Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: Source/core/animation/css/CSSAnimatableValueFactory.cpp

Issue 1265853003: CSSValue Immediates: Immediates from all CSSPrimitiveValue constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@tagged_ptrs_base
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 305 matching lines...) Expand 10 before | Expand all | Expand 10 after
316 return createFromFillLayers<CSSPropertyBackgroundImage>(style.background Layers(), style); 316 return createFromFillLayers<CSSPropertyBackgroundImage>(style.background Layers(), style);
317 case CSSPropertyBackgroundPositionX: 317 case CSSPropertyBackgroundPositionX:
318 return createFromFillLayers<CSSPropertyBackgroundPositionX>(style.backgr oundLayers(), style); 318 return createFromFillLayers<CSSPropertyBackgroundPositionX>(style.backgr oundLayers(), style);
319 case CSSPropertyBackgroundPositionY: 319 case CSSPropertyBackgroundPositionY:
320 return createFromFillLayers<CSSPropertyBackgroundPositionY>(style.backgr oundLayers(), style); 320 return createFromFillLayers<CSSPropertyBackgroundPositionY>(style.backgr oundLayers(), style);
321 case CSSPropertyBackgroundSize: 321 case CSSPropertyBackgroundSize:
322 return createFromFillLayers<CSSPropertyBackgroundSize>(style.backgroundL ayers(), style); 322 return createFromFillLayers<CSSPropertyBackgroundSize>(style.backgroundL ayers(), style);
323 case CSSPropertyBaselineShift: 323 case CSSPropertyBaselineShift:
324 switch (style.svgStyle().baselineShift()) { 324 switch (style.svgStyle().baselineShift()) {
325 case BS_SUPER: 325 case BS_SUPER:
326 return AnimatableUnknown::create(CSSPrimitiveValue::createIdentifier (CSSValueSuper)); 326 return AnimatableUnknown::create(CSSPrimitiveValue::create(CSSValueS uper));
327 case BS_SUB: 327 case BS_SUB:
328 return AnimatableUnknown::create(CSSPrimitiveValue::createIdentifier (CSSValueSub)); 328 return AnimatableUnknown::create(CSSPrimitiveValue::create(CSSValueS ub));
329 default: 329 default:
330 return createFromLength(style.baselineShiftValue(), style); 330 return createFromLength(style.baselineShiftValue(), style);
331 } 331 }
332 case CSSPropertyBorderBottomColor: 332 case CSSPropertyBorderBottomColor:
333 return createFromColor(property, style); 333 return createFromColor(property, style);
334 case CSSPropertyBorderBottomLeftRadius: 334 case CSSPropertyBorderBottomLeftRadius:
335 return createFromLengthSize(style.borderBottomLeftRadius(), style); 335 return createFromLengthSize(style.borderBottomLeftRadius(), style);
336 case CSSPropertyBorderBottomRightRadius: 336 case CSSPropertyBorderBottomRightRadius:
337 return createFromLengthSize(style.borderBottomRightRadius(), style); 337 return createFromLengthSize(style.borderBottomRightRadius(), style);
338 case CSSPropertyBorderBottomWidth: 338 case CSSPropertyBorderBottomWidth:
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
589 if (style.hasAutoZIndex()) 589 if (style.hasAutoZIndex())
590 return AnimatableUnknown::create(CSSValueAuto); 590 return AnimatableUnknown::create(CSSValueAuto);
591 return createFromDouble(style.zIndex()); 591 return createFromDouble(style.zIndex());
592 default: 592 default:
593 ASSERT_NOT_REACHED(); 593 ASSERT_NOT_REACHED();
594 return nullptr; 594 return nullptr;
595 } 595 }
596 } 596 }
597 597
598 } // namespace blink 598 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp ('k') | Source/core/css/CSSPrimitiveValue.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698