Source/core/animation/VisibilityStyleInterpolation.cpp - Issue 1265853003: CSSValue Immediates: Immediates from all CSSPrimitiveValue constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/VisibilityStyleInterpolation.cpp

Issue 1265853003: CSSValue Immediates: Immediates from all CSSPrimitiveValue constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@tagged_ptrs_base

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/animation/ShadowStyleInterpolationTest.cpp ('k') | Source/core/animation/VisibilityStyleInterpolationTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/VisibilityStyleInterpolation.cpp

diff --git a/Source/core/animation/VisibilityStyleInterpolation.cpp b/Source/core/animation/VisibilityStyleInterpolation.cpp

index 5feddd100fea0628671874084df0bcf5f31f31c0..004d16d3d5ded3621a4b27280d122cc053d6aa76 100644

--- a/Source/core/animation/VisibilityStyleInterpolation.cpp

+++ b/Source/core/animation/VisibilityStyleInterpolation.cpp

@@ -35,8 +35,8 @@ PassRefPtrWillBeRawPtr<CSSValue> VisibilityStyleInterpolation::interpolableValue

InterpolableNumber* number = toInterpolableNumber(value);

if (number->value() > 0)

- return CSSPrimitiveValue::createIdentifier(CSSValueVisible);

- return CSSPrimitiveValue::createIdentifier(notVisible);

+ return CSSPrimitiveValue::create(CSSValueVisible);

+ return CSSPrimitiveValue::create(notVisible);

}

void VisibilityStyleInterpolation::apply(StyleResolverState& state) const