Source/core/animation/VisibilityStyleInterpolationTest.cpp - Issue 1265853003: CSSValue Immediates: Immediates from all CSSPrimitiveValue constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/VisibilityStyleInterpolationTest.cpp

Issue 1265853003: CSSValue Immediates: Immediates from all CSSPrimitiveValue constructors (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@tagged_ptrs_base

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/animation/VisibilityStyleInterpolation.cpp ('k') | Source/core/animation/animatable/AnimatableValueTestHelperTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/VisibilityStyleInterpolationTest.cpp

diff --git a/Source/core/animation/VisibilityStyleInterpolationTest.cpp b/Source/core/animation/VisibilityStyleInterpolationTest.cpp

index 3557532163af1ca7e78266d35505b2d4669df02a..3744e35e2fa335a6038c6b14bd82e8a466405388 100644

--- a/Source/core/animation/VisibilityStyleInterpolationTest.cpp

+++ b/Source/core/animation/VisibilityStyleInterpolationTest.cpp

@@ -39,21 +39,21 @@ protected:

TEST_F(AnimationVisibilityStyleInterpolationTest, ValueIDs)

{

- RefPtrWillBeRawPtr<CSSValue> value = roundTrip(CSSPrimitiveValue::createIdentifier(CSSValueVisible), CSSValueHidden);

+ RefPtrWillBeRawPtr<CSSValue> value = roundTrip(CSSPrimitiveValue::create(CSSValueVisible), CSSValueHidden);

testPrimitiveValue(value, CSSValueVisible);

- value = roundTrip(CSSPrimitiveValue::createIdentifier(CSSValueCollapse), CSSValueCollapse);

+ value = roundTrip(CSSPrimitiveValue::create(CSSValueCollapse), CSSValueCollapse);

testPrimitiveValue(value, CSSValueCollapse);

- value = roundTrip(CSSPrimitiveValue::createIdentifier(CSSValueHidden), CSSValueHidden);

+ value = roundTrip(CSSPrimitiveValue::create(CSSValueHidden), CSSValueHidden);

testPrimitiveValue(value, CSSValueHidden);

}

TEST_F(AnimationVisibilityStyleInterpolationTest, Interpolation)

{

RefPtrWillBeRawPtr<Interpolation> interpolation = VisibilityStyleInterpolation::create(

- *CSSPrimitiveValue::createIdentifier(CSSValueHidden),

- *CSSPrimitiveValue::createIdentifier(CSSValueVisible),

+ *CSSPrimitiveValue::create(CSSValueHidden),

+ *CSSPrimitiveValue::create(CSSValueVisible),

CSSPropertyVisibility);

interpolation->interpolate(0, 0.0);