Issue 1252683002: CSSValue Immediates: Change RefPtr<CSSValue> to store tagged pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1252683002: CSSValue Immediates: Change RefPtr<CSSValue> to store tagged pointers (Closed)

Created:
5 years, 5 months ago by sashab

Modified:
5 years, 4 months ago

Reviewers:

CC:
blink-reviews, dglazkov+blink, rwlbuis, apavlov+blink_chromium.org, blink-reviews-css, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

CSSValue Immediates: Change RefPtr<CSSValue> to store tagged pointers Specializes RefPtr<CSSValue> and RefPtr<CSSPrimitiveValue> to be able to store immediates, as well as objects. Also modified the CSSPrimitiveValue::create() methods to create immediates for doubles, colors, valueIDs and propertyIDs, where possible. This is part of a larger refactor of CSSValue to introduce immediates, discussed on the bug. BUG=486252 COMMIT=false

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+554 lines, -303 lines)			Patch
M	Source/core/css/CSSPrimitiveValue.h	View	1 2 3 4 5 6 7 8	9 chunks	+247 lines, -96 lines	0 comments	Download
M	Source/core/css/CSSPrimitiveValue.cpp	View	1 2 3 4 5	27 chunks	+91 lines, -56 lines	0 comments	Download
M	Source/core/css/CSSPrimitiveValueMappings.h	View	1	100 chunks	+114 lines, -114 lines	0 comments	Download
M	Source/core/css/CSSValue.h	View	1 2 3 4 5 6 7 8	5 chunks	+79 lines, -35 lines	0 comments	Download
M	Source/core/css/CSSValue.cpp	View	1 2 3 4 5	7 chunks	+23 lines, -2 lines	0 comments	Download

Dependent Patchsets:

Issue 1265853003 Patch 1

Issue 1268683002 Patch 1

Issue 1265903002 Patch 1

Issue 1252683002: CSSValue Immediates: Change RefPtr<CSSValue> to store tagged pointers (Closed)

Description

Patch Set 1 #

Patch Set 2 : Small equality fix #

Patch Set 3 : Small fix for windows compile #

Patch Set 4 : Attempt to fix template linking errors #

Patch Set 5 : Added micro-benchmark and more inlining/optimizations #

Patch Set 6 : Patch reduction to most basic #

Patch Set 7 : Small fix #

Patch Set 8 : Small ordering fix to fix function matching #

Patch Set 9 : Small fix for windows #

Patch Set 10 : Rebase #