Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 1263063003: Revert of Create classes_util API, change discover to return a list instead of a dict. (Closed)

Created:
5 years, 4 months ago by Avi (use Gerrit)
Modified:
5 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, telemetry-reviews_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Create classes_util API, change discover to return a list instead of a dict. (patchset #5 id:120001 of https://codereview.chromium.org/1244223002/) Reason for revert: This appears to break the XP telemetry tests. Details on the bug. Original issue's description: > Create classes_util API, change discover to return a list instead of a dict. > > BUG=498968 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect > > Committed: https://crrev.com/e6cbec4747aa7fe3c96b1cdb89de21ae77b30ab0 > Cr-Commit-Position: refs/heads/master@{#341129} TBR=dtu@chromium.org,bengr@chromium.org,aiolos@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=498968 Committed: https://crrev.com/c85e3e1af7e170d5f8ec2b012df6e9337d2352bb Cr-Commit-Position: refs/heads/master@{#341218}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -162 lines) Patch
M content/test/gpu/gpu_tests/gpu_test_base_unittest.py View 3 chunks +9 lines, -5 lines 0 comments Download
M content/test/gpu/page_sets/__init__.py View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/__init__.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/chrome_proxy/live_tests/pagesets/__init__.py View 1 chunk +3 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/benchmark_smoke_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/benchmark_unittest.py View 2 chunks +4 lines, -3 lines 0 comments Download
M tools/perf/benchmarks/skpicture_printer.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/perf/measurements/measurement_smoke_test.py View 2 chunks +5 lines, -5 lines 0 comments Download
M tools/perf/page_sets/__init__.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/perf/profile_creators/profile_generator.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/benchmark_runner.py View 2 chunks +4 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/core/discover.py View 5 chunks +29 lines, -15 lines 0 comments Download
M tools/telemetry/telemetry/core/discover_unittest.py View 1 chunk +69 lines, -61 lines 0 comments Download
M tools/telemetry/telemetry/core/platform.py View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/profiler/profiler_finder.py View 1 chunk +4 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/internal/platform/tracing_controller_backend.py View 1 chunk +4 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/internal/util/find_dependencies.py View 2 chunks +5 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/record_wpr.py View 2 chunks +5 lines, -3 lines 0 comments Download
M tools/telemetry/telemetry/testing/story_set_smoke_test.py View 2 chunks +4 lines, -4 lines 0 comments Download
D tools/telemetry/telemetry/util/classes_util.py View 1 chunk +0 lines, -27 lines 0 comments Download
M tools/telemetry/telemetry/value/__init__.py View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Avi (use Gerrit)
Created Revert of Create classes_util API, change discover to return a list instead of a ...
5 years, 4 months ago (2015-07-30 23:04:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1263063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1263063003/1
5 years, 4 months ago (2015-07-30 23:04:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-07-30 23:09:50 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c85e3e1af7e170d5f8ec2b012df6e9337d2352bb Cr-Commit-Position: refs/heads/master@{#341218}
5 years, 4 months ago (2015-07-30 23:11:00 UTC) #4
aiolos (Not reviewing)
5 years, 4 months ago (2015-07-30 23:34:14 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1262623007/ by aiolos@chromium.org.

The reason for reverting is: The telemetry tests aren't broken. The
perf_unittests are because they don't pick tests in a deterministic way.
Reverting after a change to make them deterministic..

Powered by Google App Engine
This is Rietveld 408576698