Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: tools/telemetry/telemetry/value/__init__.py

Issue 1263063003: Revert of Create classes_util API, change discover to return a list instead of a dict. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/util/classes_util.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/value/__init__.py
diff --git a/tools/telemetry/telemetry/value/__init__.py b/tools/telemetry/telemetry/value/__init__.py
index e180dd304b1117ed37ef3cefcf1d09269dbf318a..a2ab23e29165a2724e2061a4b74e386d701c789f 100644
--- a/tools/telemetry/telemetry/value/__init__.py
+++ b/tools/telemetry/telemetry/value/__init__.py
@@ -22,9 +22,8 @@
"""
import os
+from telemetry.core import discover
from telemetry.core import util
-from telemetry.util import classes_util
-
# When combining a pair of Values togehter, it is sometimes ambiguous whether
# the values should be concatenated, or one should be picked as representative.
@@ -249,8 +248,9 @@
page_dict: a dictionary mapping IDs to page objects.
"""
value_dir = os.path.dirname(__file__)
- value_classes = classes_util.DiscoverClassesByClassName(
- value_dir, util.GetTelemetryDir(), Value)
+ value_classes = discover.DiscoverClasses(
+ value_dir, util.GetTelemetryDir(),
+ Value, index_by_class_name=True)
value_json_types = dict((value_classes[x].GetJSONTypeName(), x) for x in
value_classes)
« no previous file with comments | « tools/telemetry/telemetry/util/classes_util.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698