Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Unified Diff: tools/telemetry/telemetry/util/classes_util.py

Issue 1263063003: Revert of Create classes_util API, change discover to return a list instead of a dict. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/util/classes_util.py
diff --git a/tools/telemetry/telemetry/util/classes_util.py b/tools/telemetry/telemetry/util/classes_util.py
deleted file mode 100644
index 1496d896311f847ca6453caf9bb5958e9bf57126..0000000000000000000000000000000000000000
--- a/tools/telemetry/telemetry/util/classes_util.py
+++ /dev/null
@@ -1,27 +0,0 @@
-# Copyright 2015 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-from telemetry.core import discover
-from telemetry.internal.util import camel_case
-
-
-def DiscoverClasses(start_dir, top_level_dir, base_class,
- directly_constructable=False):
- return discover.DiscoverClasses(start_dir, top_level_dir, base_class,
- directly_constructable=directly_constructable)
-
-def DiscoverClassesByClassName(
- start_dir, top_level_dir, base_class, directly_constructable=False):
- classes_dict = {}
- classes = discover.DiscoverClasses(
- start_dir, top_level_dir, base_class,
- directly_constructable=directly_constructable)
- for class_obj in classes:
- classes_dict[camel_case.ToUnderscore(class_obj.__name__)] = class_obj
- return classes_dict
-
-def MaybeGetInstanceOfClass(target, start_dir, top_level_dir, cls):
- classes = DiscoverClassesByClassName(
- start_dir, top_level_dir, cls, directly_constructable=True)
- return classes[target]() if target in classes else None
« no previous file with comments | « tools/telemetry/telemetry/testing/story_set_smoke_test.py ('k') | tools/telemetry/telemetry/value/__init__.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698