Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: tools/perf/profile_creators/profile_generator.py

Issue 1263063003: Revert of Create classes_util API, change discover to return a list instead of a dict. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/page_sets/__init__.py ('k') | tools/telemetry/telemetry/benchmark_runner.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Handles generating profiles and transferring them to/from mobile devices.""" 5 """Handles generating profiles and transferring them to/from mobile devices."""
6 6
7 import logging 7 import logging
8 import optparse 8 import optparse
9 import os 9 import os
10 import shutil 10 import shutil
11 import stat 11 import stat
12 import sys 12 import sys
13 import tempfile 13 import tempfile
14 14
15 from profile_creators import profile_extender 15 from profile_creators import profile_extender
16 from telemetry.core import discover
16 from telemetry.core import util 17 from telemetry.core import util
17 from telemetry.internal.browser import browser_finder 18 from telemetry.internal.browser import browser_finder
18 from telemetry.internal.browser import browser_options 19 from telemetry.internal.browser import browser_options
19 from telemetry.internal import story_runner 20 from telemetry.internal import story_runner
20 from telemetry.util import classes_util
21 21
22 22
23 def _DiscoverProfileExtenderClasses(): 23 def _DiscoverProfileExtenderClasses():
24 profile_extenders_dir = os.path.abspath(os.path.join(util.GetBaseDir(), 24 profile_extenders_dir = os.path.abspath(os.path.join(util.GetBaseDir(),
25 os.pardir, 'perf', 'profile_creators')) 25 os.pardir, 'perf', 'profile_creators'))
26 base_dir = os.path.abspath(os.path.join(profile_extenders_dir, os.pardir)) 26 base_dir = os.path.abspath(os.path.join(profile_extenders_dir, os.pardir))
27 27
28 profile_extenders_unfiltered = classes_util.DiscoverClassesByClassName( 28 profile_extenders_unfiltered = discover.DiscoverClasses(
29 profile_extenders_dir, base_dir, profile_extender.ProfileExtender) 29 profile_extenders_dir, base_dir, profile_extender.ProfileExtender)
30 30
31 # Remove 'extender' suffix from keys. 31 # Remove 'extender' suffix from keys.
32 profile_extenders = {} 32 profile_extenders = {}
33 for test_name, test_class in profile_extenders_unfiltered.iteritems(): 33 for test_name, test_class in profile_extenders_unfiltered.iteritems():
34 assert test_name.endswith('_extender') 34 assert test_name.endswith('_extender')
35 test_name = test_name[:-len('_extender')] 35 test_name = test_name[:-len('_extender')]
36 profile_extenders[test_name] = test_class 36 profile_extenders[test_name] = test_class
37 return profile_extenders 37 return profile_extenders
38 38
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
192 ProcessCommandLineArgs(parser, options) 192 ProcessCommandLineArgs(parser, options)
193 193
194 # Generate profile. 194 # Generate profile.
195 profile_extenders = _DiscoverProfileExtenderClasses() 195 profile_extenders = _DiscoverProfileExtenderClasses()
196 profile_extender_class = profile_extenders[options.profile_type_to_generate] 196 profile_extender_class = profile_extenders[options.profile_type_to_generate]
197 197
198 generator = ProfileGenerator(profile_extender_class, 198 generator = ProfileGenerator(profile_extender_class,
199 options.profile_type_to_generate) 199 options.profile_type_to_generate)
200 generator.Create(options, options.output_dir) 200 generator.Create(options, options.output_dir)
201 return 0 201 return 0
OLDNEW
« no previous file with comments | « tools/perf/page_sets/__init__.py ('k') | tools/telemetry/telemetry/benchmark_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698