Renamed StreamSink to EventSink. Renamed signalError to addError.

Renamed StreamSink to EventSink. Renamed signalError to addError.

Committed: https://code.google.com/p/dart/source/detail?r=19683

[floitsch, 2013-03-07 14:19:34]

LGTM.

https://codereview.chromium.org/12610006/diff/1/sdk/lib/_internal/compiler/co...
File sdk/lib/_internal/compiler/compiler.dart (right):

https://codereview.chromium.org/12610006/diff/1/sdk/lib/_internal/compiler/co...
sdk/lib/_internal/compiler/compiler.dart:45: String extension);
indentation.

https://codereview.chromium.org/12610006/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/dart2js.dart (right):

https://codereview.chromium.org/12610006/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/dart2js.dart:329: void
signalError(AsyncError error) { addError(error); }
Ask Peter if we can remove signalError already. If there are no external users
it should be fine.

https://codereview.chromium.org/12610006/diff/1/sdk/lib/async/collection_sink...
File sdk/lib/async/collection_sink.dart (right):

https://codereview.chromium.org/12610006/diff/1/sdk/lib/async/collection_sink...
sdk/lib/async/collection_sink.dart:37: if (_isClosed) throw new
StateError("Singalling error on closed sink");
Signalling

https://codereview.chromium.org/12610006/diff/1/sdk/lib/async/stream.dart
File sdk/lib/async/stream.dart (right):

https://codereview.chromium.org/12610006/diff/1/sdk/lib/async/stream.dart#new...
sdk/lib/async/stream.dart:854: void signalError(AsyncError errorEvent) {
Move this method to StreamSink below. Users that use the new EventSink should
also use 'addError'.

Also: I know you don't like them, but if @deprecated works, please use it. It
will go away soon anyways.

https://codereview.chromium.org/12610006/diff/1/sdk/lib/async/stream.dart#new...
sdk/lib/async/stream.dart:863: abstract class StreamSink<T> extends EventSink<T>
{}
ditto for @deprecated.

https://codereview.chromium.org/12610006/diff/1/sdk/lib/async/stream.dart#new...
sdk/lib/async/stream.dart:894: void signalError(AsyncError error) {
addError(error); }
Add TODO?
Alternatively add comment to EventSink.signalError that instructs to 'grep' for
subclasses that implement signalError.

[Lasse Reichstein Nielsen, 2013-03-08 10:18:25]

As discussed, now creates StreamSink objects wherever we would want to create an
EventSink (except inside dart2js where it's known to work on EventSink, and
users of the api can provide either).

Peter or Nicolas, could you check the dart2js changes?

https://codereview.chromium.org/12610006/diff/1/sdk/lib/_internal/compiler/co...
File sdk/lib/_internal/compiler/compiler.dart (right):

https://codereview.chromium.org/12610006/diff/1/sdk/lib/_internal/compiler/co...
sdk/lib/_internal/compiler/compiler.dart:45: String extension);
On 2013/03/07 14:19:34, floitsch wrote:
> indentation.

Done.

https://codereview.chromium.org/12610006/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/dart2js.dart (right):

https://codereview.chromium.org/12610006/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/dart2js.dart:329: void
signalError(AsyncError error) { addError(error); }
We can't remove it, it's still in the interface (deprecated, but there). I'll
add a TODO.

https://codereview.chromium.org/12610006/diff/1/sdk/lib/async/collection_sink...
File sdk/lib/async/collection_sink.dart (right):

https://codereview.chromium.org/12610006/diff/1/sdk/lib/async/collection_sink...
sdk/lib/async/collection_sink.dart:37: if (_isClosed) throw new
StateError("Singalling error on closed sink");
Reworded to say "Adding".

https://codereview.chromium.org/12610006/diff/1/sdk/lib/async/stream.dart
File sdk/lib/async/stream.dart (right):

https://codereview.chromium.org/12610006/diff/1/sdk/lib/async/stream.dart#new...
sdk/lib/async/stream.dart:854: void signalError(AsyncError errorEvent) {
On 2013/03/07 14:19:34, floitsch wrote:
> Move this method to StreamSink below. Users that use the new EventSink should
> also use 'addError'.

That's problematic. This is very much a consumed interface.
Users create event handlers that expect a StreamSink - and we currently give
them an EventListener. I'll change the structure here, so that code *expecting*
a StreamSink will still work. 
Code creating a StreamSink and sending it to code expecting an EventSink will
fail. I can't find a way to support both.


> 
> Also: I know you don't like them, but if @deprecated works, please use it. It
> will go away soon anyways.

Done.

https://codereview.chromium.org/12610006/diff/1/sdk/lib/async/stream.dart#new...
sdk/lib/async/stream.dart:863: abstract class StreamSink<T> extends EventSink<T>
{}
On 2013/03/07 14:19:34, floitsch wrote:
> ditto for @deprecated.

Done.

https://codereview.chromium.org/12610006/diff/1/sdk/lib/async/stream.dart#new...
sdk/lib/async/stream.dart:894: void signalError(AsyncError error) {
addError(error); }
Added TODO(8997) where relevant (and created bug for it).

[ngeoffray, 2013-03-08 10:27:12]

dart2js changes LGTM

https://codereview.chromium.org/12610006/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/compiler.dart (right):

https://codereview.chromium.org/12610006/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/compiler.dart:25: * Returns a [EventSink] that will
serve as compiler output for the given
a -> an

[Lasse Reichstein Nielsen, 2013-03-08 11:22:37]

https://codereview.chromium.org/12610006/diff/8001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/compiler.dart (right):

https://codereview.chromium.org/12610006/diff/8001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/compiler.dart:25: * Returns a [EventSink] that will
serve as compiler output for the given
On 2013/03/08 10:27:12, ngeoffray wrote:
> a -> an

Done.

[Lasse Reichstein Nielsen, 2013-03-08 11:31:47]

Committed patchset #3 manually as r19683 (presubmit successful).