Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: sdk/lib/io/directory_impl.dart

Issue 12610006: Renamed StreamSink to EventSink. Renamed signalError to addError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Changed inheritance back! Now create StreamSink instead of EventSink where we create them. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/io/directory_impl.dart
diff --git a/sdk/lib/io/directory_impl.dart b/sdk/lib/io/directory_impl.dart
index 2b519e704b3c8468dff80bd3b5dc7a57f83f2301..a129cc788c51adb80813c00f3f2b71aa19270f5b 100644
--- a/sdk/lib/io/directory_impl.dart
+++ b/sdk/lib/io/directory_impl.dart
@@ -247,7 +247,7 @@ class _Directory implements Directory {
responsePort.receive((message, replyTo) {
if (message is !List || message[RESPONSE_TYPE] is !int) {
responsePort.close();
- controller.signalError(new DirectoryIOException("Internal error"));
+ controller.addError(new DirectoryIOException("Internal error"));
return;
}
switch (message[RESPONSE_TYPE]) {
@@ -261,7 +261,7 @@ class _Directory implements Directory {
var errorType =
message[RESPONSE_ERROR][_ERROR_RESPONSE_ERROR_TYPE];
if (errorType == _ILLEGAL_ARGUMENT_RESPONSE) {
- controller.signalError(new ArgumentError());
+ controller.addError(new ArgumentError());
} else if (errorType == _OSERROR_RESPONSE) {
var responseError = message[RESPONSE_ERROR];
var err = new OSError(
@@ -269,12 +269,12 @@ class _Directory implements Directory {
responseError[_OSERROR_RESPONSE_ERROR_CODE]);
var errorPath = message[RESPONSE_PATH];
if (errorPath == null) errorPath = path;
- controller.signalError(
+ controller.addError(
new DirectoryIOException("Directory listing failed",
errorPath,
err));
} else {
- controller.signalError(new DirectoryIOException("Internal error"));
+ controller.addError(new DirectoryIOException("Internal error"));
}
break;
case LIST_DONE:

Powered by Google App Engine
This is Rietveld 408576698