Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: utils/tests/pub/error_group_test.dart

Issue 12610006: Renamed StreamSink to EventSink. Renamed signalError to addError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Changed inheritance back! Now create StreamSink instead of EventSink where we create them. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« sdk/lib/_internal/compiler/compiler.dart ('K') | « utils/pub/utils.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/tests/pub/error_group_test.dart
diff --git a/utils/tests/pub/error_group_test.dart b/utils/tests/pub/error_group_test.dart
index c2f10fea199500bdc933becf2fb05442e8c4cba2..b3e0ba0c40e9c8450bf7cde83cd0fa2c399371d1 100644
--- a/utils/tests/pub/error_group_test.dart
+++ b/utils/tests/pub/error_group_test.dart
@@ -218,14 +218,14 @@ main() {
'listener', () {
expect(stream.first, throwsFormatException);
// errorGroup shouldn't top-level the exception
- controller.signalError(new AsyncError(new FormatException()));
+ controller.addError(new AsyncError(new FormatException()));
});
test('should notify the error group of an exception from the stream even '
'if it has a listener', () {
expect(stream.first, throwsFormatException);
expect(errorGroup.done, throwsFormatException);
- controller.signalError(new AsyncError(new FormatException()));
+ controller.addError(new AsyncError(new FormatException()));
});
test('should pass a signaled exception to the stream if it has a listener '
@@ -262,7 +262,7 @@ main() {
test("should pipe an exception from the stream to .done if the stream "
"doesn't have a listener", () {
expect(errorGroup.done, throwsFormatException);
- controller.signalError(new AsyncError(new FormatException()));
+ controller.addError(new AsyncError(new FormatException()));
// A listener added afterwards should see an empty stream, since it's not
// single-subscription
@@ -310,7 +310,7 @@ main() {
test("should pipe an exception from the stream to .done if the stream "
"doesn't have a listener", () {
expect(errorGroup.done, throwsFormatException);
- controller.signalError(new AsyncError(new FormatException()));
+ controller.addError(new AsyncError(new FormatException()));
// A listener added afterwards should receive the exception
expect(errorGroup.done.catchError((_) {
@@ -353,7 +353,7 @@ main() {
expect(stream2.first, throwsFormatException);
expect(errorGroup.done, throwsFormatException);
- controller1.signalError(new AsyncError(new FormatException()));
+ controller1.addError(new AsyncError(new FormatException()));
});
test("each future should be able to emit values independently", () {
@@ -372,7 +372,7 @@ main() {
expect(stream1.toList().then((_) {
// shouldn't cause a top-level exception
- controller2.signalError(new AsyncError(new FormatException()));
+ controller2.addError(new AsyncError(new FormatException()));
}), completes);
});
@@ -407,7 +407,7 @@ main() {
expect(future, throwsFormatException);
expect(errorGroup.done, throwsFormatException);
- controller.signalError(new AsyncError(new FormatException()));
+ controller.addError(new AsyncError(new FormatException()));
});
test("should pipe exceptions from the future to the stream", () {
@@ -435,7 +435,7 @@ main() {
expect(future.then((_) {
// shouldn't cause a top-level exception
- controller.signalError(new AsyncError(new FormatException()));
+ controller.addError(new AsyncError(new FormatException()));
}), completes);
});
« sdk/lib/_internal/compiler/compiler.dart ('K') | « utils/pub/utils.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698