Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: sdk/lib/isolate/isolate_stream.dart

Issue 12610006: Renamed StreamSink to EventSink. Renamed signalError to addError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Changed inheritance back! Now create StreamSink instead of EventSink where we create them. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/isolate/isolate_stream.dart
diff --git a/sdk/lib/isolate/isolate_stream.dart b/sdk/lib/isolate/isolate_stream.dart
index d72389faa355903e40ff38162f2c4bdeb9fda831..4cb39f1aa9402750c335c057dc62676517daeac3 100644
--- a/sdk/lib/isolate/isolate_stream.dart
+++ b/sdk/lib/isolate/isolate_stream.dart
@@ -126,6 +126,7 @@ class IsolateStream extends Stream<dynamic> {
* [IsolateSink]s can be transmitted to other isolates.
*/
class IsolateSink extends StreamSink<dynamic> {
+ // TODO(8997): Implement EventSink instead.
bool _isClosed = false;
final SendPort _port;
IsolateSink._fromPort(this._port);
@@ -149,7 +150,7 @@ class IsolateSink extends StreamSink<dynamic> {
_port.send(mangled);
}
- void signalError(AsyncError errorEvent) {
+ void addError(AsyncError errorEvent) {
throw new UnimplementedError("signalError on isolate streams");
}

Powered by Google App Engine
This is Rietveld 408576698