[nacltoons] Rename core classes in accordance with doc.

[nacltoons] Rename core classes in accordance with doc.

game_manager is now in charge of creating scenes, and
moving between them.  gameplay_scene used to do this but
now we no longer subclass scene at all.

physics_layer -> level_layer


BUG=

Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1527

[noelallen1, 2013-03-09 01:20:37]

A new name nits.

WRT UILayer dereferencing GameManager, as we add the a generic UI layer defined
by ui.def, and add the ability to pass messages between game.lua and ui.lua this
should fall out.

https://codereview.chromium.org/12579005/diff/6001/nacltoons/src/game_manager.cc
File nacltoons/src/game_manager.cc (right):

https://codereview.chromium.org/12579005/diff/6001/nacltoons/src/game_manager...
nacltoons/src/game_manager.cc:20: CCLayer* physics =
LevelLayer::create(level_number_);
level?

https://codereview.chromium.org/12579005/diff/6001/nacltoons/src/game_manager...
nacltoons/src/game_manager.cc:37: CCLayer* ui = UILayer::create();
How does the ui layer get populated?

https://codereview.chromium.org/12579005/diff/6001/nacltoons/src/level_layer.h
File nacltoons/src/level_layer.h (right):

https://codereview.chromium.org/12579005/diff/6001/nacltoons/src/level_layer....
nacltoons/src/level_layer.h:20: * Layer layer in which gameplay takes place. 
This layer contains
Level

https://codereview.chromium.org/12579005/diff/6001/nacltoons/src/ui_layer.cc
File nacltoons/src/ui_layer.cc (right):

https://codereview.chromium.org/12579005/diff/6001/nacltoons/src/ui_layer.cc#...
nacltoons/src/ui_layer.cc:11: CCLog("Restart pressed");
Why does the UILayer have a restart?

https://codereview.chromium.org/12579005/diff/6001/nacltoons/src/ui_layer.cc#...
nacltoons/src/ui_layer.cc:22: void UILayer::ToggleDebug(CCObject* sender) {
Is the LAYER LEVEL a child of the UILayer?  I thought they were both children of
the scene created by the GameManager.  Should this function be removed?

[noelallen1, 2013-03-09 01:20:46]

lgtm

[Sam Clegg, 2013-03-09 01:35:13]

https://codereview.chromium.org/12579005/diff/6001/nacltoons/src/game_manager.cc
File nacltoons/src/game_manager.cc (right):

https://codereview.chromium.org/12579005/diff/6001/nacltoons/src/game_manager...
nacltoons/src/game_manager.cc:20: CCLayer* physics =
LevelLayer::create(level_number_);
On 2013/03/09 01:20:37, noelallen1 wrote:
> level?

Done.

https://codereview.chromium.org/12579005/diff/6001/nacltoons/src/game_manager...
nacltoons/src/game_manager.cc:37: CCLayer* ui = UILayer::create();
On 2013/03/09 01:20:37, noelallen1 wrote:
> How does the ui layer get populated?

It self-populates on init().

In cocos there seem to be two styles:

 - create generic layer and populate it from the outside
 - subclass layer and populate in init().

https://codereview.chromium.org/12579005/diff/6001/nacltoons/src/level_layer.h
File nacltoons/src/level_layer.h (right):

https://codereview.chromium.org/12579005/diff/6001/nacltoons/src/level_layer....
nacltoons/src/level_layer.h:20: * Layer layer in which gameplay takes place. 
This layer contains
On 2013/03/09 01:20:37, noelallen1 wrote:
> Level

Done.

https://codereview.chromium.org/12579005/diff/6001/nacltoons/src/ui_layer.cc
File nacltoons/src/ui_layer.cc (right):

https://codereview.chromium.org/12579005/diff/6001/nacltoons/src/ui_layer.cc#...
nacltoons/src/ui_layer.cc:11: CCLog("Restart pressed");
On 2013/03/09 01:20:37, noelallen1 wrote:
> Why does the UILayer have a restart?

It main sense because it contains the UI menu with the 
Restart button on it.

I don't see why we shouldn't have the event handlers point outside the layer I
guess.  For example we could have the
handler send the Restart() callback directly to the GameManger in this case?

https://codereview.chromium.org/12579005/diff/6001/nacltoons/src/ui_layer.cc#...
nacltoons/src/ui_layer.cc:22: void UILayer::ToggleDebug(CCObject* sender) {
On 2013/03/09 01:20:37, noelallen1 wrote:
> Is the LAYER LEVEL a child of the UILayer?  I thought they were both children
of
> the scene created by the GameManager.  Should this function be removed?

No they are siblings.  This code access a sibling by tag by first asking for its
own parent.

[Sam Clegg, 2013-03-09 01:35:47]

Committed patchset #3 manually as r1527 (presubmit successful).