Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1257623002: Componentize FakeSigninManager and SigninManager prefs (Closed)

Created:
5 years, 5 months ago by droger
Modified:
5 years, 5 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, dbeam+watch-options_chromium.org, David Black, devtools-reviews_chromium.org, dhollowa+watch_chromium.org, donnd+watch_chromium.org, dougw+watch_chromium.org, extensions-reviews_chromium.org, Jered, jfweitz+watch_chromium.org, kinuko+fileapi, kmadhusu+watch_chromium.org, maniscalco+watch_chromium.org, maxbogue+watch_chromium.org, melevin+watch_chromium.org, michaelpg+watch-options_chromium.org, nhiroki, noyau+watch_chromium.org, pfeldman, plaree+watch_chromium.org, pvalenzuela+watch_chromium.org, samarth+watch_chromium.org, sdefresne+watch_chromium.org, skanuj+watch_chromium.org, tfarina, tim+watch_chromium.org, tzik, yurys, zea+watch_chromium.org, bzanotti
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize FakeSigninManager and SigninManager prefs This CL moves FakeSigninManager to the signin component. It also moves the registration of SigninManager preferences. BUG=332107 TBR=jochen Committed: https://crrev.com/4f489e64ce17f7775d3b56b7e7fce630ff5fb521 Cr-Commit-Position: refs/heads/master@{#340311}

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : Review comment #

Total comments: 2

Patch Set 6 : Review comments #

Total comments: 3

Patch Set 7 : Review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -473 lines) Patch
M chrome/browser/BUILD.gn View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/app_controller_mac_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/identity_apitest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc View 1 2 3 4 5 6 5 chunks +4 lines, -23 lines 0 comments Download
M chrome/browser/signin/account_reconcilor_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/cross_device_promo_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/signin/fake_signin_manager.h View 1 chunk +0 lines, -83 lines 0 comments Download
D chrome/browser/signin/fake_signin_manager.cc View 1 chunk +0 lines, -111 lines 0 comments Download
A + chrome/browser/signin/fake_signin_manager_builder.h View 1 2 1 chunk +27 lines, -21 lines 0 comments Download
A + chrome/browser/signin/fake_signin_manager_builder.cc View 1 2 1 chunk +13 lines, -87 lines 0 comments Download
M chrome/browser/signin/signin_error_notifier_ash_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/signin_global_error_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/signin/signin_manager_factory.cc View 2 chunks +2 lines, -26 lines 0 comments Download
M chrome/browser/signin/signin_tracker_unittest.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_startup_unittest.cc View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/sync/sync_ui_util_unittest.cc View 3 chunks +10 lines, -3 lines 0 comments Download
M chrome/browser/ui/search/search_tab_helper_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_sync_starter_unittest.cc View 1 2 2 chunks +11 lines, -4 lines 0 comments Download
M chrome/browser/ui/sync/sync_promo_ui_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/bookmarks/bookmark_bubble_view_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/sync_setup_handler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/chrome_render_view_host_test_harness.cc View 2 chunks +14 lines, -6 lines 0 comments Download
M components/signin.gypi View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M components/signin/core/browser/BUILD.gn View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
A + components/signin/core/browser/fake_signin_manager.h View 1 2 3 4 5 6 chunks +11 lines, -24 lines 0 comments Download
A + components/signin/core/browser/fake_signin_manager.cc View 1 2 3 4 5 2 chunks +29 lines, -52 lines 0 comments Download
M components/signin/core/browser/signin_manager_base.h View 1 2 3 4 2 chunks +11 lines, -0 lines 0 comments Download
M components/signin/core/browser/signin_manager_base.cc View 2 chunks +33 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1257663002 Patch 140001

Messages

Total messages: 51 (23 generated)
droger
5 years, 5 months ago (2015-07-24 11:08:56 UTC) #4
sdefresne
https://codereview.chromium.org/1257623002/diff/100001/components/signin/core/browser/signin_manager_base.h File components/signin/core/browser/signin_manager_base.h (right): https://codereview.chromium.org/1257623002/diff/100001/components/signin/core/browser/signin_manager_base.h#newcode39 components/signin/core/browser/signin_manager_base.h:39: namespace user_prefs { nit: put after SigninClient forward-declaration (more ...
5 years, 5 months ago (2015-07-24 12:22:05 UTC) #5
droger
https://codereview.chromium.org/1257623002/diff/100001/components/signin/core/browser/signin_manager_base.h File components/signin/core/browser/signin_manager_base.h (right): https://codereview.chromium.org/1257623002/diff/100001/components/signin/core/browser/signin_manager_base.h#newcode39 components/signin/core/browser/signin_manager_base.h:39: namespace user_prefs { On 2015/07/24 12:22:05, sdefresne wrote: > ...
5 years, 5 months ago (2015-07-24 12:54:59 UTC) #6
Roger Tawa OOO till Jul 10th
lgtm, one comment below. https://codereview.chromium.org/1257623002/diff/120001/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc File chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc (right): https://codereview.chromium.org/1257623002/diff/120001/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc#newcode109 chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc:109: }; It's always kind of ...
5 years, 5 months ago (2015-07-24 13:31:18 UTC) #7
droger
CC bzanotti FYI
5 years, 5 months ago (2015-07-24 13:34:36 UTC) #8
droger
Thanks for the review, done. https://codereview.chromium.org/1257623002/diff/120001/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc File chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc (right): https://codereview.chromium.org/1257623002/diff/120001/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc#newcode109 chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc:109: }; On 2015/07/24 13:31:18, ...
5 years, 5 months ago (2015-07-24 13:57:50 UTC) #9
droger
TBR=jochen for #include changes and callsites updates outside of signin.
5 years, 5 months ago (2015-07-24 14:00:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257623002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257623002/140001
5 years, 5 months ago (2015-07-24 14:00:35 UTC) #14
Roger Tawa OOO till Jul 10th
https://codereview.chromium.org/1257623002/diff/140001/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc File chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc (right): https://codereview.chromium.org/1257623002/diff/140001/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc#newcode98 chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc:98: } Nit: not possible to use BuildFakeSigninManagerBase() in this ...
5 years, 5 months ago (2015-07-24 14:46:50 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257623002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257623002/140001
5 years, 5 months ago (2015-07-24 14:55:52 UTC) #18
droger
https://codereview.chromium.org/1257623002/diff/140001/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc File chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc (right): https://codereview.chromium.org/1257623002/diff/140001/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc#newcode98 chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc:98: } On 2015/07/24 14:46:50, Roger Tawa wrote: > Nit: ...
5 years, 5 months ago (2015-07-24 14:57:03 UTC) #20
droger
https://codereview.chromium.org/1257623002/diff/140001/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc File chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc (right): https://codereview.chromium.org/1257623002/diff/140001/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc#newcode98 chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc:98: } On 2015/07/24 14:57:03, droger wrote: > On 2015/07/24 ...
5 years, 5 months ago (2015-07-24 15:03:19 UTC) #21
droger
On 2015/07/24 14:46:50, Roger Tawa wrote: > https://codereview.chromium.org/1257623002/diff/140001/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc > File chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc (right): > > https://codereview.chromium.org/1257623002/diff/140001/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc#newcode98 ...
5 years, 5 months ago (2015-07-24 15:42:19 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257623002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257623002/160001
5 years, 5 months ago (2015-07-24 15:42:39 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_arm_compile on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compile/builds/25097) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 5 months ago (2015-07-24 15:48:44 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257623002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257623002/160001
5 years, 5 months ago (2015-07-24 15:59:28 UTC) #29
commit-bot: I haz the power
Try jobs failed on following builders: linux_arm_compile on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compile/builds/25111) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 5 months ago (2015-07-24 16:04:58 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257623002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257623002/160001
5 years, 5 months ago (2015-07-24 16:30:01 UTC) #33
commit-bot: I haz the power
Try jobs failed on following builders: linux_arm_compile on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compile/builds/25149)
5 years, 5 months ago (2015-07-24 16:35:39 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257623002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257623002/160001
5 years, 5 months ago (2015-07-24 16:45:39 UTC) #37
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_clobber_rel_ng/builds/49882)
5 years, 5 months ago (2015-07-24 16:50:51 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257623002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257623002/160001
5 years, 5 months ago (2015-07-24 17:10:25 UTC) #41
commit-bot: I haz the power
Try jobs failed on following builders: linux_arm_compile on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compile/builds/25184)
5 years, 5 months ago (2015-07-24 17:16:07 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257623002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257623002/160001
5 years, 5 months ago (2015-07-24 17:17:43 UTC) #45
commit-bot: I haz the power
Try jobs failed on following builders: linux_arm_compile on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_arm_compile/builds/25188)
5 years, 5 months ago (2015-07-24 17:21:33 UTC) #47
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257623002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257623002/160001
5 years, 5 months ago (2015-07-24 18:49:08 UTC) #49
commit-bot: I haz the power
Committed patchset #7 (id:160001)
5 years, 5 months ago (2015-07-24 19:28:05 UTC) #50
commit-bot: I haz the power
5 years, 5 months ago (2015-07-24 19:28:53 UTC) #51
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/4f489e64ce17f7775d3b56b7e7fce630ff5fb521
Cr-Commit-Position: refs/heads/master@{#340311}

Powered by Google App Engine
This is Rietveld 408576698