chrome/browser/extensions/api/identity/identity_apitest.cc - Issue 1257623002: Componentize FakeSigninManager and SigninManager prefs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/identity/identity_apitest.cc

Issue 1257623002: Componentize FakeSigninManager and SigninManager prefs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comment Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/device/webrtc/devtools_bridge_client_browsertest.cc ('k') | chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/identity/identity_apitest.cc

diff --git a/chrome/browser/extensions/api/identity/identity_apitest.cc b/chrome/browser/extensions/api/identity/identity_apitest.cc

index fc4ecc80d0e90e1dbafb0ae243a48ed9a370da20..fe3ec93ecfa4a4e2cebb31e4249f718e9052118d 100644

--- a/chrome/browser/extensions/api/identity/identity_apitest.cc

+++ b/chrome/browser/extensions/api/identity/identity_apitest.cc

@@ -22,7 +22,7 @@

#include "chrome/browser/signin/account_tracker_service_factory.h"

#include "chrome/browser/signin/fake_gaia_cookie_manager_service.h"

#include "chrome/browser/signin/fake_profile_oauth2_token_service_builder.h"

-#include "chrome/browser/signin/fake_signin_manager.h"

+#include "chrome/browser/signin/fake_signin_manager_builder.h"

#include "chrome/browser/signin/gaia_cookie_manager_service_factory.h"

#include "chrome/browser/signin/profile_oauth2_token_service_factory.h"

#include "chrome/browser/signin/signin_manager_factory.h"

@@ -553,7 +553,7 @@ class IdentityTestWithSignin : public AsyncExtensionBrowserTest {

// creating the browser so that a bunch of classes don't register as

// observers and end up needing to unregister when the fake is substituted.

SigninManagerFactory::GetInstance()->SetTestingFactory(

- context, &FakeSigninManagerBase::Build);

+ context, &BuildFakeSigninManagerBase);

ProfileOAuth2TokenServiceFactory::GetInstance()->SetTestingFactory(

context, &BuildFakeProfileOAuth2TokenService);

GaiaCookieManagerServiceFactory::GetInstance()->SetTestingFactory(