chrome/browser/signin/signin_global_error_unittest.cc - Issue 1257623002: Componentize FakeSigninManager and SigninManager prefs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/signin_global_error_unittest.cc

Issue 1257623002: Componentize FakeSigninManager and SigninManager prefs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comment Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/signin/signin_error_notifier_ash_unittest.cc ('k') | chrome/browser/signin/signin_manager_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/signin_global_error_unittest.cc

diff --git a/chrome/browser/signin/signin_global_error_unittest.cc b/chrome/browser/signin/signin_global_error_unittest.cc

index 025f540a3a4a8d2b386c6f5081c61ae3eff199a1..783aa3111d9fd55b78eabe72c14fe266d1f38d8f 100644

--- a/chrome/browser/signin/signin_global_error_unittest.cc

+++ b/chrome/browser/signin/signin_global_error_unittest.cc

@@ -13,7 +13,7 @@

#include "chrome/browser/profiles/profile_manager.h"

#include "chrome/browser/profiles/profile_metrics.h"

#include "chrome/browser/signin/fake_profile_oauth2_token_service_builder.h"

-#include "chrome/browser/signin/fake_signin_manager.h"

+#include "chrome/browser/signin/fake_signin_manager_builder.h"

#include "chrome/browser/signin/profile_oauth2_token_service_factory.h"

#include "chrome/browser/signin/signin_error_controller_factory.h"

#include "chrome/browser/signin/signin_global_error_factory.h"

@@ -48,8 +48,7 @@ class SigninGlobalErrorTest : public testing::Test {

ProfileOAuth2TokenServiceFactory::GetInstance(),

BuildFakeProfileOAuth2TokenService));

testing_factories.push_back(std::make_pair(

- SigninManagerFactory::GetInstance(),

- FakeSigninManagerBase::Build));

+ SigninManagerFactory::GetInstance(), BuildFakeSigninManagerBase));

profile_ = profile_manager_.CreateTestingProfile(

"Person 1", scoped_ptr<PrefServiceSyncable>(),

base::UTF8ToUTF16("Person 1"), 0, std::string(), testing_factories);

« no previous file with comments | « chrome/browser/signin/signin_error_notifier_ash_unittest.cc ('k') | chrome/browser/signin/signin_manager_factory.cc » ('j') | no next file with comments »