chrome/browser/signin/signin_error_notifier_ash_unittest.cc - Issue 1257623002: Componentize FakeSigninManager and SigninManager prefs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/signin_error_notifier_ash_unittest.cc

Issue 1257623002: Componentize FakeSigninManager and SigninManager prefs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review comment Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/signin/signin_error_notifier_ash_unittest.cc

diff --git a/chrome/browser/signin/signin_error_notifier_ash_unittest.cc b/chrome/browser/signin/signin_error_notifier_ash_unittest.cc

index dfa4fbbf1f5c9454eef30f68f97e24f8e2427713..79f363bad03e91fcf33c187305b8bfc7c67c9054 100644

--- a/chrome/browser/signin/signin_error_notifier_ash_unittest.cc

+++ b/chrome/browser/signin/signin_error_notifier_ash_unittest.cc

@@ -9,7 +9,7 @@

#include "chrome/browser/browser_process.h"

#include "chrome/browser/notifications/notification.h"

#include "chrome/browser/notifications/notification_ui_manager.h"

-#include "chrome/browser/signin/fake_signin_manager.h"

+#include "chrome/browser/signin/fake_signin_manager_builder.h"

#include "chrome/browser/signin/signin_error_controller_factory.h"

#include "chrome/browser/signin/signin_error_notifier_factory_ash.h"

#include "chrome/browser/signin/signin_manager_factory.h"

@@ -63,7 +63,7 @@ class SigninErrorNotifierTest : public AshTestBase {

// Create a signed-in profile.

TestingProfile::Builder builder;

builder.AddTestingFactory(SigninManagerFactory::GetInstance(),

- FakeSigninManagerBase::Build);

+ BuildFakeSigninManagerBase);

profile_ = builder.Build();

profile_->set_profile_name(kTestAccountId);

« no previous file with comments | « chrome/browser/signin/fake_signin_manager_builder.cc ('k') | chrome/browser/signin/signin_global_error_unittest.cc » ('j') | no next file with comments »