Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: chrome/browser/signin/signin_global_error_unittest.cc

Issue 1257623002: Componentize FakeSigninManager and SigninManager prefs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review comment Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/signin/signin_global_error.h" 5 #include "chrome/browser/signin/signin_global_error.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/prefs/pref_service.h" 8 #include "base/prefs/pref_service.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "base/test/histogram_tester.h" 10 #include "base/test/histogram_tester.h"
11 #include "chrome/browser/prefs/pref_service_syncable.h" 11 #include "chrome/browser/prefs/pref_service_syncable.h"
12 #include "chrome/browser/profiles/profile_info_cache.h" 12 #include "chrome/browser/profiles/profile_info_cache.h"
13 #include "chrome/browser/profiles/profile_manager.h" 13 #include "chrome/browser/profiles/profile_manager.h"
14 #include "chrome/browser/profiles/profile_metrics.h" 14 #include "chrome/browser/profiles/profile_metrics.h"
15 #include "chrome/browser/signin/fake_profile_oauth2_token_service_builder.h" 15 #include "chrome/browser/signin/fake_profile_oauth2_token_service_builder.h"
16 #include "chrome/browser/signin/fake_signin_manager.h" 16 #include "chrome/browser/signin/fake_signin_manager_builder.h"
17 #include "chrome/browser/signin/profile_oauth2_token_service_factory.h" 17 #include "chrome/browser/signin/profile_oauth2_token_service_factory.h"
18 #include "chrome/browser/signin/signin_error_controller_factory.h" 18 #include "chrome/browser/signin/signin_error_controller_factory.h"
19 #include "chrome/browser/signin/signin_global_error_factory.h" 19 #include "chrome/browser/signin/signin_global_error_factory.h"
20 #include "chrome/browser/signin/signin_manager_factory.h" 20 #include "chrome/browser/signin/signin_manager_factory.h"
21 #include "chrome/browser/ui/global_error/global_error_service.h" 21 #include "chrome/browser/ui/global_error/global_error_service.h"
22 #include "chrome/browser/ui/global_error/global_error_service_factory.h" 22 #include "chrome/browser/ui/global_error/global_error_service_factory.h"
23 #include "chrome/common/pref_names.h" 23 #include "chrome/common/pref_names.h"
24 #include "chrome/test/base/testing_browser_process.h" 24 #include "chrome/test/base/testing_browser_process.h"
25 #include "chrome/test/base/testing_profile.h" 25 #include "chrome/test/base/testing_profile.h"
26 #include "chrome/test/base/testing_profile_manager.h" 26 #include "chrome/test/base/testing_profile_manager.h"
(...skipping 14 matching lines...) Expand all
41 41
42 void SetUp() override { 42 void SetUp() override {
43 ASSERT_TRUE(profile_manager_.SetUp()); 43 ASSERT_TRUE(profile_manager_.SetUp());
44 44
45 // Create a signed-in profile. 45 // Create a signed-in profile.
46 TestingProfile::TestingFactories testing_factories; 46 TestingProfile::TestingFactories testing_factories;
47 testing_factories.push_back(std::make_pair( 47 testing_factories.push_back(std::make_pair(
48 ProfileOAuth2TokenServiceFactory::GetInstance(), 48 ProfileOAuth2TokenServiceFactory::GetInstance(),
49 BuildFakeProfileOAuth2TokenService)); 49 BuildFakeProfileOAuth2TokenService));
50 testing_factories.push_back(std::make_pair( 50 testing_factories.push_back(std::make_pair(
51 SigninManagerFactory::GetInstance(), 51 SigninManagerFactory::GetInstance(), BuildFakeSigninManagerBase));
52 FakeSigninManagerBase::Build));
53 profile_ = profile_manager_.CreateTestingProfile( 52 profile_ = profile_manager_.CreateTestingProfile(
54 "Person 1", scoped_ptr<PrefServiceSyncable>(), 53 "Person 1", scoped_ptr<PrefServiceSyncable>(),
55 base::UTF8ToUTF16("Person 1"), 0, std::string(), testing_factories); 54 base::UTF8ToUTF16("Person 1"), 0, std::string(), testing_factories);
56 55
57 SigninManagerFactory::GetForProfile(profile()) 56 SigninManagerFactory::GetForProfile(profile())
58 ->SetAuthenticatedAccountInfo(kTestAccountId, kTestUsername); 57 ->SetAuthenticatedAccountInfo(kTestAccountId, kTestUsername);
59 ProfileInfoCache& cache = 58 ProfileInfoCache& cache =
60 profile_manager_.profile_manager()->GetProfileInfoCache(); 59 profile_manager_.profile_manager()->GetProfileInfoCache();
61 cache.SetAuthInfoOfProfileAtIndex( 60 cache.SetAuthInfoOfProfileAtIndex(
62 cache.GetIndexOfProfileWithPath(profile()->GetPath()), 61 cache.GetIndexOfProfileWithPath(profile()->GetPath()),
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 161
163 ProfileMetrics::LogNumberOfProfiles( 162 ProfileMetrics::LogNumberOfProfiles(
164 testing_profile_manager()->profile_manager()); 163 testing_profile_manager()->profile_manager());
165 164
166 if (table[i].is_error) 165 if (table[i].is_error)
167 histogram_tester.ExpectBucketCount("Signin.AuthError", i, 1); 166 histogram_tester.ExpectBucketCount("Signin.AuthError", i, 1);
168 histogram_tester.ExpectBucketCount( 167 histogram_tester.ExpectBucketCount(
169 "Profile.NumberOfProfilesWithAuthErrors", table[i].is_error, 1); 168 "Profile.NumberOfProfilesWithAuthErrors", table[i].is_error, 1);
170 } 169 }
171 } 170 }
OLDNEW
« no previous file with comments | « chrome/browser/signin/signin_error_notifier_ash_unittest.cc ('k') | chrome/browser/signin/signin_manager_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698