Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1257333002: Change GrDefaultGeoProcFactory to a namespace (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@localcoordscleanup
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Change GrDefaultGeoProcFactory to a namespace BUG=skia: Committed: https://skia.googlesource.com/skia/+/7a0d697ed69610efac1b964896edfc9bd869243c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -24 lines) Patch
M src/gpu/GrDefaultGeoProcFactory.h View 2 chunks +18 lines, -19 lines 0 comments Download
M src/gpu/GrDefaultGeoProcFactory.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrRectBatch.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
joshualitt
5 years, 4 months ago (2015-07-28 15:22:53 UTC) #2
robertphillips
lgtm
5 years, 4 months ago (2015-07-28 16:07:43 UTC) #3
joshualitt
I think this is pretty innocuous, but could you take a look at the use ...
5 years, 4 months ago (2015-07-28 16:11:41 UTC) #5
bsalomon
lgtm
5 years, 4 months ago (2015-07-28 16:17:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1257333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1257333002/1
5 years, 4 months ago (2015-07-28 17:01:53 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 17:20:11 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7a0d697ed69610efac1b964896edfc9bd869243c

Powered by Google App Engine
This is Rietveld 408576698