Cleanup GrDefaultGeoProcFactory localCoords

Cleanup GrDefaultGeoProcFactory localCoords

TBR=bsalomon@google.com
BUG=skia:

Committed: https://skia.googlesource.com/skia/+/0d986d877edae36ad7dc6fbdbc69a56ca9372702

[joshualitt, 2015-07-28 14:13:32]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com

[joshualitt, 2015-07-28 14:13:32]

ptal, this is just the API portion, and wiring up rectbatch.

[bsalomon, 2015-07-28 14:39:08]

https://codereview.chromium.org/1257193002/diff/40001/src/gpu/GrDefaultGeoPro...
File src/gpu/GrDefaultGeoProcFactory.cpp (right):

https://codereview.chromium.org/1257193002/diff/40001/src/gpu/GrDefaultGeoPro...
src/gpu/GrDefaultGeoProcFactory.cpp:293: return DefaultGeoProc::Create(flags,
I think it'd be nice to get rid of this factory and replace all callers with the
new ones.

https://codereview.chromium.org/1257193002/diff/40001/src/gpu/GrDefaultGeoPro...
File src/gpu/GrDefaultGeoProcFactory.h (right):

https://codereview.chromium.org/1257193002/diff/40001/src/gpu/GrDefaultGeoPro...
src/gpu/GrDefaultGeoProcFactory.h:133: // can fail if the viewmatrix is
noninvertible
I think this needs a little bit of explanation. "Use this factory to create a GP
that expects a device space vertex position attribute. The view matrix must
still be provided to compute correctly transformed coordinates for
GrFragmentProcessors. It may fail if the view matrix is not invertible."

[joshualitt, 2015-07-28 14:51:54]

On 2015/07/28 14:39:08, bsalomon wrote:
>
https://codereview.chromium.org/1257193002/diff/40001/src/gpu/GrDefaultGeoPro...
> File src/gpu/GrDefaultGeoProcFactory.cpp (right):
> 
>
https://codereview.chromium.org/1257193002/diff/40001/src/gpu/GrDefaultGeoPro...
> src/gpu/GrDefaultGeoProcFactory.cpp:293: return DefaultGeoProc::Create(flags,
> I think it'd be nice to get rid of this factory and replace all callers with
the
> new ones.
> 
>
https://codereview.chromium.org/1257193002/diff/40001/src/gpu/GrDefaultGeoPro...
> File src/gpu/GrDefaultGeoProcFactory.h (right):
> 
>
https://codereview.chromium.org/1257193002/diff/40001/src/gpu/GrDefaultGeoPro...
> src/gpu/GrDefaultGeoProcFactory.h:133: // can fail if the viewmatrix is
> noninvertible
> I think this needs a little bit of explanation. "Use this factory to create a
GP
> that expects a device space vertex position attribute. The view matrix must
> still be provided to compute correctly transformed coordinates for
> GrFragmentProcessors. It may fail if the view matrix is not invertible."

Comment added.  I'll start posting CLs after this one to roll out the new
factories to all GrBatches, and deprecate the old way.

[joshualitt, 2015-07-28 16:51:51]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2015-07-28 16:52:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1257193002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1257193002/60001

[joshualitt, 2015-07-28 16:52:57]

The CQ bit was unchecked by joshualitt@google.com

[joshualitt, 2015-07-28 16:59:04]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-07-28 16:59:09]

The CQ bit was unchecked by joshualitt@google.com

[joshualitt, 2015-07-28 17:00:30]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2015-07-28 17:00:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1257193002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1257193002/60001

[commit-bot: I haz the power, 2015-07-28 17:01:21]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/0d986d877edae36ad7dc6fbdbc69a56ca9372702