Use new API everywhere for GrDefaultGeoProcFactory

Use new API everywhere for GrDefaultGeoProcFactory

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/801823b3d825d96baadeb9077c5ed1a8ada05cf2

Committed: https://skia.googlesource.com/skia/+/df0c55785033c191d2d509c22662861588e4acd8

[joshualitt, 2015-07-28 19:35:45]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com, robertphillips@google.com

[joshualitt, 2015-07-28 19:35:45]

ptal.  I can probably extract some of the common factory patterns to the
GrDefaultGeoProcFactory namespace if you guys prefer

[joshualitt, 2015-07-28 19:35:46]

ptal.  I can probably extract some of the common factory patterns to the
GrDefaultGeoProcFactory namespace if you guys prefer

[bsalomon, 2015-07-28 20:14:48]

https://codereview.chromium.org/1261083003/diff/1/src/gpu/GrAAConvexPathRende...
File src/gpu/GrAAConvexPathRenderer.cpp (right):

https://codereview.chromium.org/1261083003/diff/1/src/gpu/GrAAConvexPathRende...
src/gpu/GrAAConvexPathRenderer.cpp:742: LocalCoords
localCoords(LocalCoords::kUsePosition_Type);
Let's see if we can always use CreateForDeviceSpace for all cases where the
caller will transform the geometry to device space (and perhaps make the VM a
required param for the other factory function).

[robertphillips, 2015-07-29 13:09:44]

https://codereview.chromium.org/1261083003/diff/1/gm/convexpolyeffect.cpp
File gm/convexpolyeffect.cpp (right):

https://codereview.chromium.org/1261083003/diff/1/gm/convexpolyeffect.cpp#new...
gm/convexpolyeffect.cpp:161: GrColor color = 0xff000000;
"Color gpColor(0xFF000000);" ?

https://codereview.chromium.org/1261083003/diff/1/src/gpu/GrAAConvexPathRende...
File src/gpu/GrAAConvexPathRenderer.cpp (right):

https://codereview.chromium.org/1261083003/diff/1/src/gpu/GrAAConvexPathRende...
src/gpu/GrAAConvexPathRenderer.cpp:744: } else {
extra space ?

https://codereview.chromium.org/1261083003/diff/1/src/gpu/GrAALinearizingConv...
File src/gpu/GrAALinearizingConvexPathRenderer.cpp (right):

https://codereview.chromium.org/1261083003/diff/1/src/gpu/GrAALinearizingConv...
src/gpu/GrAALinearizingConvexPathRenderer.cpp:119: } else {
extra space ?

https://codereview.chromium.org/1261083003/diff/1/src/gpu/GrAARectRenderer.cpp
File src/gpu/GrAARectRenderer.cpp (right):

https://codereview.chromium.org/1261083003/diff/1/src/gpu/GrAARectRenderer.cp...
src/gpu/GrAARectRenderer.cpp:33: 
Can we have one copy of this helper method some where ? (This seems like the 3rd
copy I've seen).

[joshualitt, 2015-07-29 15:44:38]

On 2015/07/29 13:09:44, robertphillips wrote:
> https://codereview.chromium.org/1261083003/diff/1/gm/convexpolyeffect.cpp
> File gm/convexpolyeffect.cpp (right):
> 
>
https://codereview.chromium.org/1261083003/diff/1/gm/convexpolyeffect.cpp#new...
> gm/convexpolyeffect.cpp:161: GrColor color = 0xff000000;
> "Color gpColor(0xFF000000);" ?
> 
>
https://codereview.chromium.org/1261083003/diff/1/src/gpu/GrAAConvexPathRende...
> File src/gpu/GrAAConvexPathRenderer.cpp (right):
> 
>
https://codereview.chromium.org/1261083003/diff/1/src/gpu/GrAAConvexPathRende...
> src/gpu/GrAAConvexPathRenderer.cpp:744: } else {
> extra space ?
> 
>
https://codereview.chromium.org/1261083003/diff/1/src/gpu/GrAALinearizingConv...
> File src/gpu/GrAALinearizingConvexPathRenderer.cpp (right):
> 
>
https://codereview.chromium.org/1261083003/diff/1/src/gpu/GrAALinearizingConv...
> src/gpu/GrAALinearizingConvexPathRenderer.cpp:119: } else {
> extra space ?
> 
> https://codereview.chromium.org/1261083003/diff/1/src/gpu/GrAARectRenderer.cpp
> File src/gpu/GrAARectRenderer.cpp (right):
> 
>
https://codereview.chromium.org/1261083003/diff/1/src/gpu/GrAARectRenderer.cp...
> src/gpu/GrAARectRenderer.cpp:33: 
> Can we have one copy of this helper method some where ? (This seems like the
3rd
> copy I've seen).

feedback inc

[bsalomon, 2015-07-29 19:43:55]

https://codereview.chromium.org/1261083003/diff/40001/src/gpu/GrDefaultGeoPro...
File src/gpu/GrDefaultGeoProcFactory.h (right):

https://codereview.chromium.org/1261083003/diff/40001/src/gpu/GrDefaultGeoPro...
src/gpu/GrDefaultGeoProcFactory.h:147: const GrGeometryProcessor*
CreateForDeviceSpaceAlphaTweakIfPossible(const SkMatrix& viewMatrix,
Head spinning, what if I set coverageIgnored and tweakAlphaForCoverage? How do I
know if I have a coverage attribute after this returns?

[joshualitt, 2015-08-03 14:45:02]

On 2015/07/29 19:43:55, bsalomon wrote:
>
https://codereview.chromium.org/1261083003/diff/40001/src/gpu/GrDefaultGeoPro...
> File src/gpu/GrDefaultGeoProcFactory.h (right):
> 
>
https://codereview.chromium.org/1261083003/diff/40001/src/gpu/GrDefaultGeoPro...
> src/gpu/GrDefaultGeoProcFactory.h:147: const GrGeometryProcessor*
> CreateForDeviceSpaceAlphaTweakIfPossible(const SkMatrix& viewMatrix,
> Head spinning, what if I set coverageIgnored and tweakAlphaForCoverage? How do
I
> know if I have a coverage attribute after this returns?

Okay, I removed this function ptal.  I could have had the caller pass in the
coverage type, but that three statement 'if' was like 80% of the code savings.

[bsalomon, 2015-08-03 15:54:49]

lgtm

[joshualitt, 2015-08-03 15:55:36]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2015-08-03 15:55:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1261083003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1261083003/80001

[commit-bot: I haz the power, 2015-08-03 16:03:36]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/801823b3d825d96baadeb9077c5ed1a8ada05cf2

[joshualitt, 2015-08-03 16:31:56]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1264283004/ by joshualitt@google.com.

The reason for reverting is: breaking things.

[joshualitt, 2015-08-03 18:27:50]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-08-03 18:27:51]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1261083003/#ps100001
(title: "tweaks")

[commit-bot: I haz the power, 2015-08-03 18:28:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1261083003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1261083003/100001

[commit-bot: I haz the power, 2015-08-03 18:35:33]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/df0c55785033c191d2d509c22662861588e4acd8