Make GrGLEffects use an interface to append their code.

Make GrGLEffects use an interface to append their code.

A small step towards encapsulating GrGLShaderBuilder.
Committed: https://code.google.com/p/skia/source/detail?r=8018

[bsalomon, 2013-03-07 15:08:41]

Makes the code strings private.

[robertphillips, 2013-03-07 15:23:16]

lgtm

https://codereview.chromium.org/12547012/diff/21003/src/core/SkString.cpp
File src/core/SkString.cpp (right):

https://codereview.chromium.org/12547012/diff/21003/src/core/SkString.cpp#new...
src/core/SkString.cpp:526: 
Why not use this one?

https://codereview.chromium.org/12547012/diff/21003/src/gpu/gl/GrGLProgram.cpp
File src/gpu/gl/GrGLProgram.cpp (right):

https://codereview.chromium.org/12547012/diff/21003/src/gpu/gl/GrGLProgram.cp...
src/gpu/gl/GrGLProgram.cpp:537:
builder->fVSAttrs.push_back().set(kVec4f_GrSLType,
spaces

https://codereview.chromium.org/12547012/diff/21003/src/ports/SkDebug_win.cpp
File src/ports/SkDebug_win.cpp (right):

https://codereview.chromium.org/12547012/diff/21003/src/ports/SkDebug_win.cpp...
src/ports/SkDebug_win.cpp:23: vsnprintf(buffer, kBufferSize, format, args);
Does this work?

[bsalomon, 2013-03-07 15:44:22]

https://codereview.chromium.org/12547012/diff/21003/src/core/SkString.cpp
File src/core/SkString.cpp (right):

https://codereview.chromium.org/12547012/diff/21003/src/core/SkString.cpp#new...
src/core/SkString.cpp:526: 
On 2013/03/07 15:23:16, robertphillips wrote:
> Why not use this one?

Because I've already created a va_list in GrGLShaderBuilder.

https://codereview.chromium.org/12547012/diff/21003/src/gpu/gl/GrGLProgram.cpp
File src/gpu/gl/GrGLProgram.cpp (right):

https://codereview.chromium.org/12547012/diff/21003/src/gpu/gl/GrGLProgram.cp...
src/gpu/gl/GrGLProgram.cpp:537:
builder->fVSAttrs.push_back().set(kVec4f_GrSLType,
On 2013/03/07 15:23:16, robertphillips wrote:
> spaces

Done.

https://codereview.chromium.org/12547012/diff/21003/src/ports/SkDebug_win.cpp
File src/ports/SkDebug_win.cpp (right):

https://codereview.chromium.org/12547012/diff/21003/src/ports/SkDebug_win.cpp...
src/ports/SkDebug_win.cpp:23: vsnprintf(buffer, kBufferSize, format, args);
On 2013/03/07 15:23:16, robertphillips wrote:
> Does this work?

yes! And our long strings don't get cut off.

[jvanverth1, 2013-03-07 16:03:22]

LGTM

On 2013/03/07 15:44:22, bsalomon wrote:
> https://codereview.chromium.org/12547012/diff/21003/src/core/SkString.cpp
> File src/core/SkString.cpp (right):
> 
>
https://codereview.chromium.org/12547012/diff/21003/src/core/SkString.cpp#new...
> src/core/SkString.cpp:526: 
> On 2013/03/07 15:23:16, robertphillips wrote:
> > Why not use this one?
> 
> Because I've already created a va_list in GrGLShaderBuilder.
> 
> https://codereview.chromium.org/12547012/diff/21003/src/gpu/gl/GrGLProgram.cpp
> File src/gpu/gl/GrGLProgram.cpp (right):
> 
>
https://codereview.chromium.org/12547012/diff/21003/src/gpu/gl/GrGLProgram.cp...
> src/gpu/gl/GrGLProgram.cpp:537:
> builder->fVSAttrs.push_back().set(kVec4f_GrSLType,
> On 2013/03/07 15:23:16, robertphillips wrote:
> > spaces
> 
> Done.
> 
> https://codereview.chromium.org/12547012/diff/21003/src/ports/SkDebug_win.cpp
> File src/ports/SkDebug_win.cpp (right):
> 
>
https://codereview.chromium.org/12547012/diff/21003/src/ports/SkDebug_win.cpp...
> src/ports/SkDebug_win.cpp:23: vsnprintf(buffer, kBufferSize, format, args);
> On 2013/03/07 15:23:16, robertphillips wrote:
> > Does this work?
> 
> yes! And our long strings don't get cut off.

[bsalomon, 2013-03-07 17:07:05]

Committed patchset #4 manually as r8018 (presubmit successful).