Make GrGLEffects use an interface to append their code.

src/core/SkString.cpp

 
 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #include "SkString.h"
@@ skipping 505 matching lines @@
     char*   stop = SkStrAppendScalar(buffer, value);
     this->insert(offset, buffer, stop - buffer);
 }
 
 void SkString::printf(const char format[], ...) {
     char    buffer[kBufferSize];
     ARGS_TO_BUFFER(format, buffer, kBufferSize);
 
     this->set(buffer, strlen(buffer));
 }
 

[robertphillips, 2013/03/07 15:23:16]

Why not use this one?

[bsalomon, 2013/03/07 15:44:22]

Because I've already created a va_list in GrGLShaderBuilder.

 void SkString::appendf(const char format[], ...) {
     char    buffer[kBufferSize];
     ARGS_TO_BUFFER(format, buffer, kBufferSize);
 
     this->append(buffer, strlen(buffer));
 }
 
+void SkString::appendf(const char format[], va_list args) {
+    char    buffer[kBufferSize];
+    VSNPRINTF(buffer, kBufferSize, format, args);
+
+    this->append(buffer, strlen(buffer));
+}
+
 void SkString::prependf(const char format[], ...) {
     char    buffer[kBufferSize];
     ARGS_TO_BUFFER(format, buffer, kBufferSize);
 
     this->prepend(buffer, strlen(buffer));
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 
 void SkString::remove(size_t offset, size_t length) {
@@ skipping 61 matching lines @@
 SkString SkStringPrintf(const char* format, ...) {
     SkString formattedOutput;
     char buffer[kBufferSize];
     ARGS_TO_BUFFER(format, buffer, kBufferSize);
     formattedOutput.set(buffer);
     return formattedOutput;
 }
 
 #undef VSNPRINTF
 #undef SNPRINTF