Issue 12544006: Revert 186416

Issue 12544006: Revert 186416 (Closed)

Created:
7 years, 9 months ago by Zhenyao Mo

Modified:
7 years, 9 months ago

Reviewers:
greggman

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 186416 > Use client side arrays for GL_STREAM_DRAW attributes > > Certain GPU/drivers are slow when using constantly changing > vertex buffers. They also run out of memory as the pipeline > the buffers so while a buffer is in used being drawn to they > can't delete it immediately when you upload new data to the > buffer. > > This is an attempt to work around that issue seemlessly by > using client side arrays for buffers marked as GL_STREAM_DRAW > > BUG=178093 > > > Review URL: https://chromiumcodereview.appspot.com/12494005 TBR=gman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186459

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+248 lines, -835 lines)			Patch
M	gpu/command_buffer/build_gles2_cmd_buffer.py	View	3 chunks	+3 lines, -18 lines	0 comments	Download
M	gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h	View	9 chunks	+7 lines, -7 lines	0 comments	Download
M	gpu/command_buffer/service/buffer_manager.h	View	11 chunks	+13 lines, -50 lines	0 comments	Download
M	gpu/command_buffer/service/buffer_manager.cc	View	4 chunks	+9 lines, -77 lines	0 comments	Download
M	gpu/command_buffer/service/buffer_manager_unittest.cc	View	11 chunks	+102 lines, -193 lines	0 comments	Download
M	gpu/command_buffer/service/context_group.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	gpu/command_buffer/service/feature_info.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gpu/command_buffer/service/feature_info.cc	View	5 chunks	+1 line, -16 lines	0 comments	Download
M	gpu/command_buffer/service/feature_info_unittest.cc	View	2 chunks	+0 lines, -31 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View	8 chunks	+76 lines, -56 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_autogen.h	View	12 chunks	+20 lines, -13 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	gpu/command_buffer/service/query_manager_unittest.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	gpu/command_buffer/service/test_helper.h	View	2 chunks	+0 lines, -8 lines	0 comments	Download
M	gpu/command_buffer/service/test_helper.cc	View	2 chunks	+0 lines, -26 lines	0 comments	Download
M	gpu/command_buffer/service/vertex_attrib_manager.h	View	4 chunks	+0 lines, -22 lines	0 comments	Download
M	gpu/command_buffer/service/vertex_attrib_manager.cc	View	3 chunks	+0 lines, -114 lines	0 comments	Download
M	gpu/command_buffer/service/vertex_attrib_manager_unittest.cc	View	6 chunks	+6 lines, -17 lines	0 comments	Download
D	gpu/command_buffer/tests/gl_stream_draw_unittests.cc	View	1 chunk	+0 lines, -157 lines	0 comments	Download
M	gpu/command_buffer/tests/gl_test_utils.h	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	gpu/command_buffer/tests/gl_test_utils.cc	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	gpu/gpu.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r186459.

Expand Messages | Collapse Messages