Revert 186416

gpu/command_buffer/build_gles2_cmd_buffer.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """code generator for GLES2 command buffers."""
 
 import itertools
 import os
 import os.path
@@ skipping 1158 matching lines @@
 # gen_func:     Name of function that generates GL resource for corresponding
 #               bind function.
 # states:       array of states that get set by this function corresponding to
 #               the given arguments
 # state_flag:   name of flag that is set to true when function is called.
 # no_gl:        no GL function is called.
 # valid_args:   A dictionary of argument indices to args to use in unit tests
 #               when they can not be automatically determined.
 # pepper_interface: The pepper interface that is used for this extension
 # invalid_test: False if no invalid test needed.
-# shadowed:     True = the value is shadowed so no glGetXXX call will be made.
 
 _FUNCTION_INFO = {
   'ActiveTexture': {
     'decoder_func': 'DoActiveTexture',
     'unit_test': False,
     'impl_func': False,
     'client_test': False,
   },
   'AttachShader': {'decoder_func': 'DoAttachShader'},
   'BindAttribLocation': {'type': 'GLchar', 'bucket': True, 'needs_size': True},
@@ skipping 367 matching lines @@
     'cmd_args':
         'GLidProgram program, const char* name, NonImmediate GLint* location',
     'result': ['GLint'],
   },
   'GetBooleanv': {
     'type': 'GETn',
     'result': ['SizedResult<GLboolean>'],
     'decoder_func': 'DoGetBooleanv',
     'gl_test_func': 'glGetBooleanv',
   },
-  'GetBufferParameteriv': {
-    'type': 'GETn',
-    'result': ['SizedResult<GLint>'],
-    'decoder_func': 'DoGetBufferParameteriv',
-    'expectation': False,
-    'shadowed': True,
-  },
+  'GetBufferParameteriv': {'type': 'GETn', 'result': ['SizedResult<GLint>']},
   'GetError': {
     'type': 'Is',
     'decoder_func': 'GetGLError',
     'impl_func': False,
     'result': ['GLenum'],
     'client_test': False,
   },
   'GetFloatv': {
     'type': 'GETn',
     'result': ['SizedResult<GLfloat>'],
@@ skipping 2761 matching lines @@
 """
     file.Write(code % {
         'last_arg_type': last_arg.type,
         'func_name': func.name,
       })
     func.WriteHandlerValidation(file)
     code = """  // Check that the client initialized the result.
   if (result->size != 0) {
     return error::kInvalidArguments;
   }
+  CopyRealGLErrorsToWrapper();
 """
-    shadowed = func.GetInfo('shadowed')
-    if not shadowed:
-      file.Write("  CopyRealGLErrorsToWrapper();\n");
     file.Write(code)
     func.WriteHandlerImplementation(file)
-    if shadowed:
-      code = """  result->SetNumResults(num_values);
-  return error::kNoError;
-}
-"""
-    else:
-     code = """  GLenum error = glGetError();
+    code = """  GLenum error = glGetError();
   if (error == GL_NO_ERROR) {
     result->SetNumResults(num_values);
   } else {
     SetGLError(error, "", "");
   }
   return error::kNoError;
 }
 
 """
     file.Write(code)
@@ skipping 3234 matching lines @@
     gen.WriteGLES2Header("../GLES2/gl2chromium_autogen.h")
 
   if gen.errors > 0:
     print "%d errors" % gen.errors
     return 1
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv[1:]))