Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Unified Diff: gpu/command_buffer/build_gles2_cmd_buffer.py

Issue 12544006: Revert 186416 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/build_gles2_cmd_buffer.py
===================================================================
--- gpu/command_buffer/build_gles2_cmd_buffer.py (revision 186458)
+++ gpu/command_buffer/build_gles2_cmd_buffer.py (working copy)
@@ -1176,7 +1176,6 @@
# when they can not be automatically determined.
# pepper_interface: The pepper interface that is used for this extension
# invalid_test: False if no invalid test needed.
-# shadowed: True = the value is shadowed so no glGetXXX call will be made.
_FUNCTION_INFO = {
'ActiveTexture': {
@@ -1564,13 +1563,7 @@
'decoder_func': 'DoGetBooleanv',
'gl_test_func': 'glGetBooleanv',
},
- 'GetBufferParameteriv': {
- 'type': 'GETn',
- 'result': ['SizedResult<GLint>'],
- 'decoder_func': 'DoGetBufferParameteriv',
- 'expectation': False,
- 'shadowed': True,
- },
+ 'GetBufferParameteriv': {'type': 'GETn', 'result': ['SizedResult<GLint>']},
'GetError': {
'type': 'Is',
'decoder_func': 'GetGLError',
@@ -4352,19 +4345,11 @@
if (result->size != 0) {
return error::kInvalidArguments;
}
+ CopyRealGLErrorsToWrapper();
"""
- shadowed = func.GetInfo('shadowed')
- if not shadowed:
- file.Write(" CopyRealGLErrorsToWrapper();\n");
file.Write(code)
func.WriteHandlerImplementation(file)
- if shadowed:
- code = """ result->SetNumResults(num_values);
- return error::kNoError;
-}
-"""
- else:
- code = """ GLenum error = glGetError();
+ code = """ GLenum error = glGetError();
if (error == GL_NO_ERROR) {
result->SetNumResults(num_values);
} else {
« no previous file with comments | « no previous file | gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698