Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_autogen.h

Issue 12544006: Revert 186416 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/gles2_cmd_decoder_autogen.h
===================================================================
--- gpu/command_buffer/service/gles2_cmd_decoder_autogen.h (revision 186458)
+++ gpu/command_buffer/service/gles2_cmd_decoder_autogen.h (working copy)
@@ -975,11 +975,11 @@
if (params == NULL) {
return error::kOutOfBounds;
}
- CopyRealGLErrorsToWrapper();
// Check that the client initialized the result.
if (result->size != 0) {
return error::kInvalidArguments;
}
+ CopyRealGLErrorsToWrapper();
DoGetBooleanv(pname, params);
GLenum error = glGetError();
if (error == GL_NO_ERROR) {
@@ -1015,10 +1015,17 @@
if (result->size != 0) {
return error::kInvalidArguments;
}
- DoGetBufferParameteriv(target, pname, params);
- result->SetNumResults(num_values);
+ CopyRealGLErrorsToWrapper();
+ glGetBufferParameteriv(target, pname, params);
+ GLenum error = glGetError();
+ if (error == GL_NO_ERROR) {
+ result->SetNumResults(num_values);
+ } else {
+ SetGLError(error, "", "");
+ }
return error::kNoError;
}
+
error::Error GLES2DecoderImpl::HandleGetError(
uint32 immediate_data_size, const gles2::cmds::GetError& c) {
typedef cmds::GetError::Result Result;
@@ -1047,11 +1054,11 @@
if (params == NULL) {
return error::kOutOfBounds;
}
- CopyRealGLErrorsToWrapper();
// Check that the client initialized the result.
if (result->size != 0) {
return error::kInvalidArguments;
}
+ CopyRealGLErrorsToWrapper();
DoGetFloatv(pname, params);
GLenum error = glGetError();
if (error == GL_NO_ERROR) {
@@ -1092,11 +1099,11 @@
if (params == NULL) {
return error::kOutOfBounds;
}
- CopyRealGLErrorsToWrapper();
// Check that the client initialized the result.
if (result->size != 0) {
return error::kInvalidArguments;
}
+ CopyRealGLErrorsToWrapper();
DoGetFramebufferAttachmentParameteriv(target, attachment, pname, params);
GLenum error = glGetError();
if (error == GL_NO_ERROR) {
@@ -1123,11 +1130,11 @@
if (params == NULL) {
return error::kOutOfBounds;
}
- CopyRealGLErrorsToWrapper();
// Check that the client initialized the result.
if (result->size != 0) {
return error::kInvalidArguments;
}
+ CopyRealGLErrorsToWrapper();
DoGetIntegerv(pname, params);
GLenum error = glGetError();
if (error == GL_NO_ERROR) {
@@ -1155,11 +1162,11 @@
if (params == NULL) {
return error::kOutOfBounds;
}
- CopyRealGLErrorsToWrapper();
// Check that the client initialized the result.
if (result->size != 0) {
return error::kInvalidArguments;
}
+ CopyRealGLErrorsToWrapper();
DoGetProgramiv(program, pname, params);
GLenum error = glGetError();
if (error == GL_NO_ERROR) {
@@ -1192,11 +1199,11 @@
if (params == NULL) {
return error::kOutOfBounds;
}
- CopyRealGLErrorsToWrapper();
// Check that the client initialized the result.
if (result->size != 0) {
return error::kInvalidArguments;
}
+ CopyRealGLErrorsToWrapper();
DoGetRenderbufferParameteriv(target, pname, params);
GLenum error = glGetError();
if (error == GL_NO_ERROR) {
@@ -1224,11 +1231,11 @@
if (params == NULL) {
return error::kOutOfBounds;
}
- CopyRealGLErrorsToWrapper();
// Check that the client initialized the result.
if (result->size != 0) {
return error::kInvalidArguments;
}
+ CopyRealGLErrorsToWrapper();
DoGetShaderiv(shader, pname, params);
GLenum error = glGetError();
if (error == GL_NO_ERROR) {
@@ -1260,11 +1267,11 @@
if (params == NULL) {
return error::kOutOfBounds;
}
- CopyRealGLErrorsToWrapper();
// Check that the client initialized the result.
if (result->size != 0) {
return error::kInvalidArguments;
}
+ CopyRealGLErrorsToWrapper();
glGetTexParameterfv(target, pname, params);
GLenum error = glGetError();
if (error == GL_NO_ERROR) {
@@ -1296,11 +1303,11 @@
if (params == NULL) {
return error::kOutOfBounds;
}
- CopyRealGLErrorsToWrapper();
// Check that the client initialized the result.
if (result->size != 0) {
return error::kInvalidArguments;
}
+ CopyRealGLErrorsToWrapper();
glGetTexParameteriv(target, pname, params);
GLenum error = glGetError();
if (error == GL_NO_ERROR) {
@@ -1328,11 +1335,11 @@
if (params == NULL) {
return error::kOutOfBounds;
}
- CopyRealGLErrorsToWrapper();
// Check that the client initialized the result.
if (result->size != 0) {
return error::kInvalidArguments;
}
+ CopyRealGLErrorsToWrapper();
DoGetVertexAttribfv(index, pname, params);
GLenum error = glGetError();
if (error == GL_NO_ERROR) {
@@ -1360,11 +1367,11 @@
if (params == NULL) {
return error::kOutOfBounds;
}
- CopyRealGLErrorsToWrapper();
// Check that the client initialized the result.
if (result->size != 0) {
return error::kInvalidArguments;
}
+ CopyRealGLErrorsToWrapper();
DoGetVertexAttribiv(index, pname, params);
GLenum error = glGetError();
if (error == GL_NO_ERROR) {
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698