cc: Chromify the Animation and LayerAnimationController classes

cc: Chromify the Animation and LayerAnimationController classes

Style-only change. Make the Animation, AnimationEvent,  AnimationCurve,
KeyframedAnimationCurve, and LayerAnimationController classes use
chromium style.

R=jamesr,enne
TBR=piman

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187463

[jamesr, 2013-03-09 02:44:55]

Needs a bit more work I think.  Can you check all the .PassAs<>() calls in that
unit test file?

https://codereview.chromium.org/12517003/diff/5001/cc/animation.cc
File cc/animation.cc (right):

https://codereview.chromium.org/12517003/diff/5001/cc/animation.cc#newcode44
cc/animation.cc:44: namespace cc { scoped_ptr<Animation> Animation::Create(
namespace cc { should be on its own line. probably want a newline after it, too

https://codereview.chromium.org/12517003/diff/5001/cc/layer_animation_control...
File cc/layer_animation_controller.cc (right):

https://codereview.chromium.org/12517003/diff/5001/cc/layer_animation_control...
cc/layer_animation_controller.cc:16: namespace cc {
LayerAnimationController::LayerAnimationController(int id)
this one's on the same line too

https://codereview.chromium.org/12517003/diff/5001/cc/layer_animation_control...
File cc/layer_animation_controller_unittest.cc (right):

https://codereview.chromium.org/12517003/diff/5001/cc/layer_animation_control...
cc/layer_animation_controller_unittest.cc:16: namespace cc { namespace {
this one's busted too

https://codereview.chromium.org/12517003/diff/5001/cc/layer_animation_control...
cc/layer_animation_controller_unittest.cc:320: .PassAs<AnimationCurve>(),
this looks weird. the .PassAss<>() is line up as if it's its own parameter, but
it's a continuation of the previous line

https://codereview.chromium.org/12517003/diff/5001/cc/layer_animation_control...
cc/layer_animation_controller_unittest.cc:361: .PassAs<AnimationCurve>(),
and here

https://codereview.chromium.org/12517003/diff/5001/cc/layer_animation_control...
cc/layer_animation_controller_unittest.cc:366: .PassAs<AnimationCurve>(),
and here

https://codereview.chromium.org/12517003/diff/5001/cc/layer_animation_control...
cc/layer_animation_controller_unittest.cc:394: .PassAs<AnimationCurve>(),
and here

https://codereview.chromium.org/12517003/diff/5001/cc/layer_animation_control...
cc/layer_animation_controller_unittest.cc:404: .PassAs<AnimationCurve>(),
yeah, lots of these

[danakj, 2013-03-09 03:01:11]

Fixed all the .PassAs() as well as ones I added recently elsewheres.

https://codereview.chromium.org/12517003/diff/5001/cc/animation.cc
File cc/animation.cc (right):

https://codereview.chromium.org/12517003/diff/5001/cc/animation.cc#newcode44
cc/animation.cc:44: namespace cc { scoped_ptr<Animation> Animation::Create(
On 2013/03/09 02:44:56, jamesr wrote:
> namespace cc { should be on its own line. probably want a newline after it,
too

oops, bad script. thanks.

https://codereview.chromium.org/12517003/diff/5001/cc/layer_animation_control...
File cc/layer_animation_controller.cc (right):

https://codereview.chromium.org/12517003/diff/5001/cc/layer_animation_control...
cc/layer_animation_controller.cc:16: namespace cc {
LayerAnimationController::LayerAnimationController(int id)
On 2013/03/09 02:44:56, jamesr wrote:
> this one's on the same line too

Done.

https://codereview.chromium.org/12517003/diff/5001/cc/layer_animation_control...
File cc/layer_animation_controller_unittest.cc (right):

https://codereview.chromium.org/12517003/diff/5001/cc/layer_animation_control...
cc/layer_animation_controller_unittest.cc:16: namespace cc { namespace {
On 2013/03/09 02:44:56, jamesr wrote:
> this one's busted too

Done.

[aelias_OOO_until_Jul13, 2013-03-09 03:22:33]

lgtm, shouldn't affect Android

[enne (OOO), 2013-03-11 21:17:43]

lgtm

https://codereview.chromium.org/12517003/diff/17001/cc/layer_animation_contro...
File cc/layer_animation_controller_unittest.cc (right):

https://codereview.chromium.org/12517003/diff/17001/cc/layer_animation_contro...
cc/layer_animation_controller_unittest.cc:414: EXPECT_EQ(0.5, dummy.opacity());
opacity is a float, here and elsewhere in this file.  (Sorry.)

[jamesr, 2013-03-11 21:30:15]

lgtm2

[danakj, 2013-03-11 23:14:50]

https://codereview.chromium.org/12517003/diff/17001/cc/layer_animation_contro...
File cc/layer_animation_controller_unittest.cc (right):

https://codereview.chromium.org/12517003/diff/17001/cc/layer_animation_contro...
cc/layer_animation_controller_unittest.cc:414: EXPECT_EQ(0.5, dummy.opacity());
On 2013/03/11 21:17:43, enne wrote:
> opacity is a float, here and elsewhere in this file.  (Sorry.)

Done.

[commit-bot: I haz the power, 2013-03-11 23:20:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/12517003/20001

[commit-bot: I haz the power, 2013-03-11 23:21:05]

Presubmit check for 12517003-20001 failed and returned exit status 1.

INFO:root:Found 45 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/cc/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/ui/compositor/PRESUBMIT.py

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    ui/compositor/layer_animation_element.cc
    ui/compositor/layer_animation_sequence.cc
    ui/compositor/transform_animation_curve_adapter.h
    ui/compositor/float_animation_curve_adapter.cc
    ui/compositor/layer_animator.cc
    ui/compositor/float_animation_curve_adapter.h
    ui/compositor/transform_animation_curve_adapter.cc
    ui/compositor/layer.cc

Presubmit checks took 3.2s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[danakj, 2013-03-11 23:27:35]

TBR=piman for the renames in ui/

[commit-bot: I haz the power, 2013-03-11 23:30:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/12517003/20001

[commit-bot: I haz the power, 2013-03-11 23:30:47]

Failed to apply patch for ui/compositor/layer.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file ui/compositor/layer.cc
  Hunk #1 FAILED at 804.
  1 out of 1 hunk FAILED -- saving rejects to file ui/compositor/layer.cc.rej

Patch:       ui/compositor/layer.cc
Index: ui/compositor/layer.cc
diff --git a/ui/compositor/layer.cc b/ui/compositor/layer.cc
index
928e6673829a2ff1f62b263d8a690368141ed02a..d5b3f093086adf5c71e28249d7fd3b379bba8ef5
100644
--- a/ui/compositor/layer.cc
+++ b/ui/compositor/layer.cc
@@ -804,12 +804,12 @@ SkColor Layer::GetColorForAnimation() const {
 
 void Layer::AddThreadedAnimation(scoped_ptr<cc::Animation> animation) {
   DCHECK(cc_layer_);
-  cc_layer_->addAnimation(animation.Pass());
+  cc_layer_->AddAnimation(animation.Pass());
 }
 
 void Layer::RemoveThreadedAnimation(int animation_id) {
   DCHECK(cc_layer_);
-  cc_layer_->removeAnimation(animation_id);
+  cc_layer_->RemoveAnimation(animation_id);
 }
 
 void Layer::CreateWebLayer() {

[commit-bot: I haz the power, 2013-03-11 23:44:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/12517003/25001

[danakj, 2013-03-12 02:49:30]

Committed patchset #7 manually as r187463 (presubmit successful).