Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 12440030: Use utils.forEach everywhere rather than Array.prototype.forEach to guard (Closed)

Created:
7 years, 9 months ago by not at google - send to devlin
Modified:
7 years, 9 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Use utils.forEach everywhere rather than Array.prototype.forEach to guard against extensions which override it. BUG=179741, 181580 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187519

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : make foreach of an array give numbers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -55 lines) Patch
M chrome/renderer/resources/extensions/app_runtime_custom_bindings.js View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/resources/extensions/binding.js View 1 6 chunks +15 lines, -14 lines 0 comments Download
M chrome/renderer/resources/extensions/content_watcher.js View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/renderer/resources/extensions/event.js View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/resources/extensions/extension_custom_bindings.js View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/resources/extensions/file_system_custom_bindings.js View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/platform_app.js View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/send_request.js View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/renderer/resources/extensions/storage_custom_bindings.js View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/renderer/resources/extensions/sync_file_system_custom_bindings.js View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/renderer/resources/extensions/tag_watcher.js View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/renderer/resources/extensions/utils.js View 1 2 3 1 chunk +14 lines, -4 lines 0 comments Download
M chrome/renderer/resources/extensions/web_view.js View 6 chunks +14 lines, -10 lines 0 comments Download
M chrome/renderer/resources/extensions/web_view_experimental.js View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
not at google - send to devlin
7 years, 9 months ago (2013-03-12 00:19:53 UTC) #1
Matt Perry
lgtm
7 years, 9 months ago (2013-03-12 00:27:34 UTC) #2
not at google - send to devlin
7 years, 9 months ago (2013-03-12 06:27:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r187519 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698