chrome/renderer/resources/extensions/extension_custom_bindings.js - Issue 12440030: Use utils.forEach everywhere rather than Array.prototype.forEach to guard

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/extension_custom_bindings.js

Issue 12440030: Use utils.forEach everywhere rather than Array.prototype.forEach to guard (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: make foreach of an array give numbers Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/event.js ('k') | chrome/renderer/resources/extensions/file_system_custom_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/extension_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/extension_custom_bindings.js b/chrome/renderer/resources/extensions/extension_custom_bindings.js

index 61e5e16b3c68c1a70ae255958fb999431e07cac1..2fe27775a79f98576970a83ff187f17a03a0e742 100644

--- a/chrome/renderer/resources/extensions/extension_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/extension_custom_bindings.js

@@ -7,6 +7,7 @@

var binding = require('binding').Binding.create('extension');

var extensionNatives = requireNative('extension');

+var forEach = require('utils').forEach;

var GetExtensionViews = extensionNatives.GetExtensionViews;

var runtimeNatives = requireNative('runtime');

var OpenChannelToExtension = runtimeNatives.OpenChannelToExtension;

@@ -78,7 +79,7 @@ binding.registerCustomHook(function(bindingsAPI, extensionId) {

// Events

'onConnect', 'onConnectExternal', 'onMessage', 'onMessageExternal'

];

- mayNeedAlias.forEach(function(alias) {

+ forEach(mayNeedAlias, function(i, alias) {

// Checking existence isn't enough since some functions are disabled via

// getters that throw exceptions. Assume that any getter is such a function.

if (chrome.runtime.hasOwnProperty(alias) &&