chrome/renderer/resources/extensions/tag_watcher.js - Issue 12440030: Use utils.forEach everywhere rather than Array.prototype.forEach to guard

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/tag_watcher.js

Issue 12440030: Use utils.forEach everywhere rather than Array.prototype.forEach to guard (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: make foreach of an array give numbers Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/sync_file_system_custom_bindings.js ('k') | chrome/renderer/resources/extensions/utils.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/tag_watcher.js

diff --git a/chrome/renderer/resources/extensions/tag_watcher.js b/chrome/renderer/resources/extensions/tag_watcher.js

index 47261febaf4b0c98898a45fb9ea0d74ad6803fae..99bfce6d55b0c522cbef62a1faa33bbb54f7ff2d 100644

--- a/chrome/renderer/resources/extensions/tag_watcher.js

+++ b/chrome/renderer/resources/extensions/tag_watcher.js

@@ -2,6 +2,8 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+var forEach = require('utils').forEach;

// Expose a function to watch the HTML tag creation via Mutation Observers.

function watchForTag(tagName, cb) {

if (!document.body)

@@ -15,7 +17,7 @@ function watchForTag(tagName, cb) {

// Observe the tags added later.

var documentObserver = new WebKitMutationObserver(function(mutations) {

- mutations.forEach(function(mutation) {

+ forEach(mutations, function(i, mutation) {

for (var i = 0, addedNode; addedNode = mutation.addedNodes[i]; i++) {

if (addedNode.tagName == tagName) {

cb(addedNode);