chrome/renderer/resources/extensions/event.js - Issue 12440030: Use utils.forEach everywhere rather than Array.prototype.forEach to guard

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/event.js

Issue 12440030: Use utils.forEach everywhere rather than Array.prototype.forEach to guard (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: make foreach of an array give numbers Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/content_watcher.js ('k') | chrome/renderer/resources/extensions/extension_custom_bindings.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/event.js

diff --git a/chrome/renderer/resources/extensions/event.js b/chrome/renderer/resources/extensions/event.js

index 59e04d5c6ae01b81d387f74753230a7fb86dc9d7..6aff8dc1bc02faa88cb736910d5aa15c4350b7d3 100644

--- a/chrome/renderer/resources/extensions/event.js

+++ b/chrome/renderer/resources/extensions/event.js

@@ -11,6 +11,7 @@

var AttachFilteredEvent = eventBindingsNatives.AttachFilteredEvent;

var DetachFilteredEvent = eventBindingsNatives.DetachFilteredEvent;

var MatchAgainstEventFilter = eventBindingsNatives.MatchAgainstEventFilter;

+ var forEach = require('utils').forEach;

var sendRequest = require('sendRequest').sendRequest;

var utils = require('utils');

var validate = require('schemaUtils').validate;

@@ -398,7 +399,7 @@

function validateRules(rules, conditions, actions) {

var conditionsSchema = buildArrayOfChoicesSchema(conditions);

var actionsSchema = buildArrayOfChoicesSchema(actions);

- rules.forEach(function(rule) {

+ forEach(rules, function(i, rule) {

validate([rule.conditions], [conditionsSchema]);

validate([rule.actions], [actionsSchema]);

})