Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2434)

Unified Diff: chrome/renderer/resources/extensions/send_request.js

Issue 12440030: Use utils.forEach everywhere rather than Array.prototype.forEach to guard (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: make foreach of an array give numbers Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/send_request.js
diff --git a/chrome/renderer/resources/extensions/send_request.js b/chrome/renderer/resources/extensions/send_request.js
index 829aee25b04a0c3e7686d55686793ad779830094..a805578ef41ce49b3b7148b7a3e4e3b05d2a4591 100644
--- a/chrome/renderer/resources/extensions/send_request.js
+++ b/chrome/renderer/resources/extensions/send_request.js
@@ -4,6 +4,7 @@
var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
var DCHECK = requireNative('logging').DCHECK;
+var forEach = require('utils').forEach;
var json = require('json');
var lastError = require('lastError');
var natives = requireNative('sendRequest');
@@ -33,11 +34,11 @@ chromeHidden.handleResponse = function(requestId, name,
chromesForLastError.push(chromeForCallback);
}
- chromesForLastError.forEach(function(c) {lastError.clear(c)});
+ forEach(chromesForLastError, function(i, c) {lastError.clear(c)});
if (!success) {
if (!error)
error = "Unknown error.";
- chromesForLastError.forEach(function(c) {lastError.set(error, c)});
+ forEach(chromesForLastError, function(i, c) {lastError.set(error, c)});
}
if (request.customCallback) {
@@ -67,7 +68,7 @@ chromeHidden.handleResponse = function(requestId, name,
}
} finally {
delete requests[requestId];
- chromesForLastError.forEach(function(c) {lastError.clear(c)});
+ forEach(chromesForLastError, function(i, c) {lastError.clear(c)});
}
};
« no previous file with comments | « chrome/renderer/resources/extensions/platform_app.js ('k') | chrome/renderer/resources/extensions/storage_custom_bindings.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698