Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1232563003: Remove 'blink::WebSerializedOrigin' (1/3) (Closed)

Created:
5 years, 5 months ago by Mike West
Modified:
5 years, 5 months ago
CC:
blink-reviews, dglazkov+blink, peter+watch_chromium.org, tyoshino+watch_chromium.org, yhirano+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove 'blink::WebSerializedOrigin' (1/3) As part of the plan to rationalize Origins across Blink and its embedder, we're dropping 'blink::WebSerializedOrigin' in favor of 'blink::WebSecurityOrigin' (which can serialize itself just fine). Patch 1 (Blink): This patch. Patch 2 (Chromium): https://codereview.chromium.org/1229783005 Patch 3 (Blink): https://codereview.chromium.org/1231643010 BUG=508896 R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198731

Patch Set 1 #

Patch Set 2 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -14 lines) Patch
M Source/modules/notifications/Notification.cpp View 4 chunks +3 lines, -4 lines 0 comments Download
M Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/websockets/DocumentWebSocketChannel.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/websockets/DocumentWebSocketChannelTest.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/exported/WebSerializedOrigin.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M public/platform/WebSerializedOrigin.h View 1 chunk +3 lines, -0 lines 0 comments Download
M public/platform/WebSocketHandle.h View 2 chunks +8 lines, -2 lines 0 comments Download
M public/platform/modules/notifications/WebNotificationManager.h View 4 chunks +30 lines, -5 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232563003/1
5 years, 5 months ago (2015-07-10 12:29:39 UTC) #2
Mike West
Jochen, WDYT?
5 years, 5 months ago (2015-07-10 12:31:11 UTC) #3
Mike West
On 2015/07/10 at 12:31:11, Mike West wrote: > Jochen, WDYT? (It's ugly at the moment, ...
5 years, 5 months ago (2015-07-10 12:31:41 UTC) #4
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-10 12:34:10 UTC) #5
Peter Beverloo
You must love doing three-sided patches ;-). Thanks for doing this!! lgtm
5 years, 5 months ago (2015-07-10 12:37:24 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/70045) (exceeded global ...
5 years, 5 months ago (2015-07-10 12:57:59 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232563003/20001
5 years, 5 months ago (2015-07-11 07:57:01 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-11 08:59:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1232563003/20001
5 years, 5 months ago (2015-07-11 09:12:06 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=198731
5 years, 5 months ago (2015-07-11 09:15:25 UTC) #17
Mike West
5 years, 5 months ago (2015-07-11 12:50:25 UTC) #18
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1235673003/ by mkwst@chromium.org.

The reason for reverting is: Blocking the roll; fails on
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...
for some reason. :/.

Powered by Google App Engine
This is Rietveld 408576698