extensions: tabs: set tab id to -1 for app/devtools windows

extensions: tabs: set tab id to -1 for app/devtools windows

Before making app & devtools windows visible through chrome.windows.*
we want to make sure the tab id of the devtools is stripped from the
tab object returned to javascript so devtools cannot be manipulated
through the chrome.tabs.* API.

BUG=394341
Committed: https://crrev.com/d2315f72405e4776861fa79919a0051538660656
Cr-Commit-Position: refs/heads/master@{#339647}

[llandwerlin-old, 2015-07-14 15:10:45]

lionel.g.landwerlin@intel.com changed reviewers:
+ dgozman@chromium.org, kalman@chromium.org

[llandwerlin-old, 2015-07-14 15:10:46]

kalman@, dgozman@: Here is a different approach to filtering out devtools
windows from the chrome.tabs API.

Given that the tab id is optional [1], we can remove it for the tab objects we
don't want extension to deal with.

[1] : https://developer.chrome.com/extensions/tabs#type-Tab

[dgozman, 2015-07-14 15:16:16]

I like this approach as it should avoid hard-to-predict bugs around too specific
devtools tab and browser.

https://codereview.chromium.org/1239643004/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_tab_util.cc (right):

https://codereview.chromium.org/1239643004/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_tab_util.cc:357: if (browser->is_devtools())
What about TabUpdatedEvent or TabsGetCurrent? Perhaps, we should filter out id
(or even a whole tab entry?) from inside CreateTabValue?

[not at google - send to devlin, 2015-07-14 17:15:14]

https://codereview.chromium.org/1239643004/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_tab_util.cc (right):

https://codereview.chromium.org/1239643004/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_tab_util.cc:357: if (browser->is_devtools())
On 2015/07/14 15:16:16, dgozman wrote:
> What about TabUpdatedEvent or TabsGetCurrent? Perhaps, we should filter out id
> (or even a whole tab entry?) from inside CreateTabValue?

CreateTabValue looks right to me.

[llandwerlin-old, 2015-07-14 17:21:03]

On 2015/07/14 17:15:14, kalman wrote:
>
https://codereview.chromium.org/1239643004/diff/1/chrome/browser/extensions/e...
> File chrome/browser/extensions/extension_tab_util.cc (right):
> 
>
https://codereview.chromium.org/1239643004/diff/1/chrome/browser/extensions/e...
> chrome/browser/extensions/extension_tab_util.cc:357: if
(browser->is_devtools())
> On 2015/07/14 15:16:16, dgozman wrote:
> > What about TabUpdatedEvent or TabsGetCurrent? Perhaps, we should filter out
id
> > (or even a whole tab entry?) from inside CreateTabValue?
> 
> CreateTabValue looks right to me.

PTAL, and thanks a lot, your feedback is really helpful.
I've added more tests for https://codereview.chromium.org/1228863006.

[not at google - send to devlin, 2015-07-14 17:40:00]

https://codereview.chromium.org/1239643004/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_tab_util.cc (right):

https://codereview.chromium.org/1239643004/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_tab_util.cc:357: if (browser->is_devtools())
On 2015/07/14 17:15:13, kalman wrote:
> On 2015/07/14 15:16:16, dgozman wrote:
> > What about TabUpdatedEvent or TabsGetCurrent? Perhaps, we should filter out
id
> > (or even a whole tab entry?) from inside CreateTabValue?
> 
> CreateTabValue looks right to me.

Actually, GetTabID looks even right-er to me. More subtle and wide-reaching, but
skimming over the call sites, it looks safe. Perhaps double-check?

It already returns -1 if there is no tab; you could additionally special-case
devtools to return -1, then not set tab ID here if it's == -1.

[not at google - send to devlin, 2015-07-14 17:41:09]

https://codereview.chromium.org/1239643004/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_tab_util.cc (right):

https://codereview.chromium.org/1239643004/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_tab_util.cc:357: if (browser->is_devtools())
On 2015/07/14 17:40:00, kalman wrote:
> On 2015/07/14 17:15:13, kalman wrote:
> > On 2015/07/14 15:16:16, dgozman wrote:
> > > What about TabUpdatedEvent or TabsGetCurrent? Perhaps, we should filter
out
> id
> > > (or even a whole tab entry?) from inside CreateTabValue?
> > 
> > CreateTabValue looks right to me.
> 
> Actually, GetTabID looks even right-er to me. More subtle and wide-reaching,
but
> skimming over the call sites, it looks safe. Perhaps double-check?
> 
> It already returns -1 if there is no tab; you could additionally special-case
> devtools to return -1, then not set tab ID here if it's == -1.

More comments:

In fact I wonder if this would break backwards compatibility at all. We must
already be setting -1 for the tab ID in some cases already, and not setting it
if it == -1 would break that. In which case, I'd set it to -1 for devtools.

[llandwerlin-old, 2015-07-16 11:58:23]

On 2015/07/14 17:41:09, kalman wrote:
>
https://codereview.chromium.org/1239643004/diff/1/chrome/browser/extensions/e...
> File chrome/browser/extensions/extension_tab_util.cc (right):
> 
>
https://codereview.chromium.org/1239643004/diff/1/chrome/browser/extensions/e...
> chrome/browser/extensions/extension_tab_util.cc:357: if
(browser->is_devtools())
> On 2015/07/14 17:40:00, kalman wrote:
> > On 2015/07/14 17:15:13, kalman wrote:
> > > On 2015/07/14 15:16:16, dgozman wrote:
> > > > What about TabUpdatedEvent or TabsGetCurrent? Perhaps, we should filter
> out
> > id
> > > > (or even a whole tab entry?) from inside CreateTabValue?
> > > 
> > > CreateTabValue looks right to me.
> > 
> > Actually, GetTabID looks even right-er to me. More subtle and wide-reaching,
> but
> > skimming over the call sites, it looks safe. Perhaps double-check?
> > 
> > It already returns -1 if there is no tab; you could additionally
special-case
> > devtools to return -1, then not set tab ID here if it's == -1.
> 
> More comments:
> 
> In fact I wonder if this would break backwards compatibility at all. We must
> already be setting -1 for the tab ID in some cases already, and not setting it
> if it == -1 would break that. In which case, I'd set it to -1 for devtools.

PTAL, thanks.

[dgozman, 2015-07-16 12:05:50]

https://codereview.chromium.org/1239643004/diff/160001/chrome/common/extensio...
File chrome/common/extensions/api/tabs.json (right):

https://codereview.chromium.org/1239643004/diff/160001/chrome/common/extensio...
chrome/common/extensions/api/tabs.json:14: "id": {"type": "integer", "minimum":
-1, "description": "The ID of the tab. Tab IDs are unique within a browser
session. Under some circumstances a Tab may not be -1, for example when querying
foreign tabs using the $(ref:sessions) API, in which case a session ID may be
present, or for applications and devtools windows."},
"may not be -1" -> "may be -1"

[llandwerlin-old, 2015-07-16 12:09:23]

https://codereview.chromium.org/1239643004/diff/160001/chrome/common/extensio...
File chrome/common/extensions/api/tabs.json (right):

https://codereview.chromium.org/1239643004/diff/160001/chrome/common/extensio...
chrome/common/extensions/api/tabs.json:14: "id": {"type": "integer", "minimum":
-1, "description": "The ID of the tab. Tab IDs are unique within a browser
session. Under some circumstances a Tab may not be -1, for example when querying
foreign tabs using the $(ref:sessions) API, in which case a session ID may be
present, or for applications and devtools windows."},
On 2015/07/16 12:05:50, dgozman wrote:
> "may not be -1" -> "may be -1"

Done, thanks.

[not at google - send to devlin, 2015-07-16 17:09:23]

https://codereview.chromium.org/1239643004/diff/180001/chrome/browser/extensi...
File chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc
(right):

https://codereview.chromium.org/1239643004/diff/180001/chrome/browser/extensi...
chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc:77: if
(params->target_tab->id < 0) {
See TAB_ID_NONE comment.

https://codereview.chromium.org/1239643004/diff/180001/chrome/browser/extensi...
File chrome/browser/extensions/api/sessions/sessions_apitest.cc (right):

https://codereview.chromium.org/1239643004/diff/180001/chrome/browser/extensi...
chrome/browser/extensions/api/sessions/sessions_apitest.cc:257: -1);  //
sessions API does not give tab IDs
I'd like to keep using the lack of a tab ID as meaning it's a session API.
Pragmatically, we shouldn't be changing APIs. Philosophically, we could say that
-1 means "there is no tab ID" whereas the lack of a tab ID means "there is a tab
ID, but we don't know it". Not that interesting a distinction to make, but
that's where we are.

https://codereview.chromium.org/1239643004/diff/180001/chrome/browser/extensi...
File chrome/browser/extensions/api/tabs/tabs_event_router.cc (right):

https://codereview.chromium.org/1239643004/diff/180001/chrome/browser/extensi...
chrome/browser/extensions/api/tabs/tabs_event_router.cc:132: if
(!browser->is_devtools() && browser->tab_strip_model()) {
For whatever reason, this condition would make more sense to me if it checked
the tab_strip_model first. if (browser->tab_strip_model() &&
!browser->is_devtools()) { ... }

https://codereview.chromium.org/1239643004/diff/180001/chrome/common/extensio...
File chrome/common/extensions/api/tabs.json (right):

https://codereview.chromium.org/1239643004/diff/180001/chrome/common/extensio...
chrome/common/extensions/api/tabs.json:14: "id": {"type": "integer", "minimum":
-1, "description": "The ID of the tab. Tab IDs are unique within a browser
session. Under some circumstances a Tab may be -1, for example when querying
foreign tabs using the $(ref:sessions) API, in which case a session ID may be
present, or for applications and devtools windows."},
We can't change the optionality of fields.

As for changing the minimum to -1, this is fine, but I'd like to take this
opportunity to define a TAB_ID_NONE similar to a WINDOW_ID_NONE:

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/exte...

and use that where you've done your != -1 or > 0 checks, and mention it here.

[llandwerlin-old, 2015-07-17 11:32:05]

https://codereview.chromium.org/1239643004/diff/180001/chrome/browser/extensi...
File chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc
(right):

https://codereview.chromium.org/1239643004/diff/180001/chrome/browser/extensi...
chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc:77: if
(params->target_tab->id < 0) {
On 2015/07/16 17:09:23, kalman wrote:
> See TAB_ID_NONE comment.

Done.

https://codereview.chromium.org/1239643004/diff/180001/chrome/browser/extensi...
File chrome/browser/extensions/api/sessions/sessions_apitest.cc (right):

https://codereview.chromium.org/1239643004/diff/180001/chrome/browser/extensi...
chrome/browser/extensions/api/sessions/sessions_apitest.cc:257: -1);  //
sessions API does not give tab IDs
On 2015/07/16 17:09:23, kalman wrote:
> I'd like to keep using the lack of a tab ID as meaning it's a session API.
> Pragmatically, we shouldn't be changing APIs. Philosophically, we could say
that
> -1 means "there is no tab ID" whereas the lack of a tab ID means "there is a
tab
> ID, but we don't know it". Not that interesting a distinction to make, but
> that's where we are.

Done.

https://codereview.chromium.org/1239643004/diff/180001/chrome/browser/extensi...
File chrome/browser/extensions/api/tabs/tabs_event_router.cc (right):

https://codereview.chromium.org/1239643004/diff/180001/chrome/browser/extensi...
chrome/browser/extensions/api/tabs/tabs_event_router.cc:132: if
(!browser->is_devtools() && browser->tab_strip_model()) {
On 2015/07/16 17:09:23, kalman wrote:
> For whatever reason, this condition would make more sense to me if it checked
> the tab_strip_model first. if (browser->tab_strip_model() &&
> !browser->is_devtools()) { ... }

Done.

https://codereview.chromium.org/1239643004/diff/180001/chrome/common/extensio...
File chrome/common/extensions/api/tabs.json (right):

https://codereview.chromium.org/1239643004/diff/180001/chrome/common/extensio...
chrome/common/extensions/api/tabs.json:14: "id": {"type": "integer", "minimum":
-1, "description": "The ID of the tab. Tab IDs are unique within a browser
session. Under some circumstances a Tab may be -1, for example when querying
foreign tabs using the $(ref:sessions) API, in which case a session ID may be
present, or for applications and devtools windows."},
On 2015/07/16 17:09:23, kalman wrote:
> We can't change the optionality of fields.
> 
> As for changing the minimum to -1, this is fine, but I'd like to take this
> opportunity to define a TAB_ID_NONE similar to a WINDOW_ID_NONE:
> 
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/common/exte...
> 
> and use that where you've done your != -1 or > 0 checks, and mention it here.

Thanks, I should have asked.

[not at google - send to devlin, 2015-07-17 16:44:58]

lgtm with the util change.

https://codereview.chromium.org/1239643004/diff/200001/chrome/browser/extensi...
File chrome/browser/extensions/api/tabs/tabs_event_router.cc (right):

https://codereview.chromium.org/1239643004/diff/200001/chrome/browser/extensi...
chrome/browser/extensions/api/tabs/tabs_event_router.cc:132: if
(browser->tab_strip_model() && !browser->is_devtools()) {
How about adding a util method to ExtensionTabUtil so that we don't need to
repeat this check so often? ExtensionTabUtil::BrowserSupportsTabs(browser) or
something.

https://codereview.chromium.org/1239643004/diff/200001/chrome/browser/extensi...
chrome/browser/extensions/api/tabs/tabs_event_router.cc:151: if
(!profile_->IsSameProfile(browser->profile()) || browser->is_devtools())
ExtensionTabUtil::BrowserSupportsTabs(browser)

https://codereview.chromium.org/1239643004/diff/200001/chrome/browser/extensi...
File chrome/browser/extensions/extension_tab_util.cc (right):

https://codereview.chromium.org/1239643004/diff/200001/chrome/browser/extensi...
chrome/browser/extensions/extension_tab_util.cc:319: if (browser &&
browser->is_devtools())
ExtensionTabUtil::BrowserSupportsTabs(browser)

https://codereview.chromium.org/1239643004/diff/200001/chrome/common/extensio...
File chrome/common/extensions/api/tabs.json (right):

https://codereview.chromium.org/1239643004/diff/200001/chrome/common/extensio...
chrome/common/extensions/api/tabs.json:14: "id": {"type": "integer", "minimum":
-1, "optional": true, "description": "The ID of the tab. Tab IDs are unique
within a browser session. Under some circumstances a Tab may not be assigned an
ID, for example when querying foreign tabs using the $(ref:sessions) API, in
which case a session ID may be present. Tab ID can also be set to
chrome.tabs.TAB_ID_NONE for applications and devtools windows."},
"applications" --> "apps"

https://codereview.chromium.org/1239643004/diff/200001/chrome/common/extensio...
chrome/common/extensions/api/tabs.json:108: "description": "The id value that
represents the absence of a chrome browser tab."
"The id value that" --> "An ID which"
"chrome" --> "Chrome"

[llandwerlin-old, 2015-07-17 17:05:04]

Thanks again for your time.

https://codereview.chromium.org/1239643004/diff/200001/chrome/browser/extensi...
File chrome/browser/extensions/api/tabs/tabs_event_router.cc (right):

https://codereview.chromium.org/1239643004/diff/200001/chrome/browser/extensi...
chrome/browser/extensions/api/tabs/tabs_event_router.cc:132: if
(browser->tab_strip_model() && !browser->is_devtools()) {
On 2015/07/17 16:44:58, kalman wrote:
> How about adding a util method to ExtensionTabUtil so that we don't need to
> repeat this check so often? ExtensionTabUtil::BrowserSupportsTabs(browser) or
> something.

Done.

https://codereview.chromium.org/1239643004/diff/200001/chrome/browser/extensi...
chrome/browser/extensions/api/tabs/tabs_event_router.cc:151: if
(!profile_->IsSameProfile(browser->profile()) || browser->is_devtools())
On 2015/07/17 16:44:58, kalman wrote:
> ExtensionTabUtil::BrowserSupportsTabs(browser)

Done.

https://codereview.chromium.org/1239643004/diff/200001/chrome/common/extensio...
File chrome/common/extensions/api/tabs.json (right):

https://codereview.chromium.org/1239643004/diff/200001/chrome/common/extensio...
chrome/common/extensions/api/tabs.json:14: "id": {"type": "integer", "minimum":
-1, "optional": true, "description": "The ID of the tab. Tab IDs are unique
within a browser session. Under some circumstances a Tab may not be assigned an
ID, for example when querying foreign tabs using the $(ref:sessions) API, in
which case a session ID may be present. Tab ID can also be set to
chrome.tabs.TAB_ID_NONE for applications and devtools windows."},
On 2015/07/17 16:44:58, kalman wrote:
> "applications" --> "apps"

Done.

https://codereview.chromium.org/1239643004/diff/200001/chrome/common/extensio...
chrome/common/extensions/api/tabs.json:108: "description": "The id value that
represents the absence of a chrome browser tab."
On 2015/07/17 16:44:58, kalman wrote:
> "The id value that" --> "An ID which"
> "chrome" --> "Chrome"

Done.

[llandwerlin-old, 2015-07-17 17:05:15]

The CQ bit was checked by lionel.g.landwerlin@intel.com

[llandwerlin-old, 2015-07-17 17:05:16]

The patchset sent to the CQ was uploaded after l-g-t-m from kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/1239643004/#ps240001
(title: "s/SupportsTab/SupportsTabs/")

[commit-bot: I haz the power, 2015-07-17 17:05:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1239643004/240001

[commit-bot: I haz the power, 2015-07-17 17:05:42]

The author lionel.g.landwerlin@intel.com has not signed Google Contributor
License Agreement. Please visit https://cla.developers.google.com to sign and
manage CLA.

[commit-bot: I haz the power, 2015-07-17 17:35:45]

The author lionel.g.landwerlin@intel.com has not signed Google Contributor
License Agreement. Please visit https://cla.developers.google.com to sign and
manage CLA.

[commit-bot: I haz the power, 2015-07-17 18:05:20]

The author lionel.g.landwerlin@intel.com has not signed Google Contributor
License Agreement. Please visit https://cla.developers.google.com to sign and
manage CLA.

[commit-bot: I haz the power, 2015-07-17 18:18:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-17 18:18:01]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[llandwerlin-old, 2015-07-20 16:56:53]

kalman@: Sorry to bother you again. After BrowserSupportsTabs() changes quite a
few tests broke. Here are a few more changes, including a new test to verify
that new chrome.tabs events are triggered for devtools.

[llandwerlin-old, 2015-07-20 17:12:37]

On 2015/07/20 16:56:53, llandwerlin wrote:
> kalman@: Sorry to bother you again. After BrowserSupportsTabs() changes quite
a
> few tests broke. Here are a few more changes, including a new test to verify
> that new chrome.tabs events are triggered for devtools.

I meant aren't triggered.

[not at google - send to devlin, 2015-07-20 21:29:18]

lgtm

https://codereview.chromium.org/1239643004/diff/300001/chrome/browser/extensi...
File chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc
(right):

https://codereview.chromium.org/1239643004/diff/300001/chrome/browser/extensi...
chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc:78:
*(params->target_tab->id) == api::tabs::TAB_ID_NONE) {
Parents aren't necessary here, you can just do *params->target_tab->id

https://codereview.chromium.org/1239643004/diff/300001/chrome/browser/extensi...
File chrome/browser/extensions/extension_tab_util.h (right):

https://codereview.chromium.org/1239643004/diff/300001/chrome/browser/extensi...
chrome/browser/extensions/extension_tab_util.h:182: // Will return false for a
devtools browser.
I'd replace the second like with: "Example of Browsers which don't support tabs
include apps and devtools."

https://codereview.chromium.org/1239643004/diff/300001/chrome/test/data/exten...
File chrome/test/data/extensions/api_test/tabs/no_events/test.js (right):

https://codereview.chromium.org/1239643004/diff/300001/chrome/test/data/exten...
chrome/test/data/extensions/api_test/tabs/no_events/test.js:6: 
I would make this slightly more succinct with a single function like

function errorListener() { ++errors; }

and then use that like

chrome.tabs.onCreated.addListener(errorListener);
chrome.tabs.onRemoved.addListener(errorListener);
chrome.tabs.onUpdated.addListener(errorListener);

https://codereview.chromium.org/1239643004/diff/300001/chrome/test/data/exten...
chrome/test/data/extensions/api_test/tabs/no_events/test.js:9:
chrome.test.assertTrue(false);
chrome.test.fail() would be more straightforward.

but that said, since you're failing the test in the chrome.test.sendMessage()
response if errors > 0, you don't need these calls to fail(). Better to
centralise.

[llandwerlin-old, 2015-07-21 09:45:41]

https://codereview.chromium.org/1239643004/diff/300001/chrome/browser/extensi...
File chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc
(right):

https://codereview.chromium.org/1239643004/diff/300001/chrome/browser/extensi...
chrome/browser/extensions/api/desktop_capture/desktop_capture_api.cc:78:
*(params->target_tab->id) == api::tabs::TAB_ID_NONE) {
On 2015/07/20 21:29:18, kalman wrote:
> Parents aren't necessary here, you can just do *params->target_tab->id

Done.

https://codereview.chromium.org/1239643004/diff/300001/chrome/browser/extensi...
File chrome/browser/extensions/extension_tab_util.h (right):

https://codereview.chromium.org/1239643004/diff/300001/chrome/browser/extensi...
chrome/browser/extensions/extension_tab_util.h:182: // Will return false for a
devtools browser.
On 2015/07/20 21:29:18, kalman wrote:
> I'd replace the second like with: "Example of Browsers which don't support
tabs
> include apps and devtools."

Done.

https://codereview.chromium.org/1239643004/diff/300001/chrome/test/data/exten...
File chrome/test/data/extensions/api_test/tabs/no_events/test.js (right):

https://codereview.chromium.org/1239643004/diff/300001/chrome/test/data/exten...
chrome/test/data/extensions/api_test/tabs/no_events/test.js:6: 
On 2015/07/20 21:29:18, kalman wrote:
> I would make this slightly more succinct with a single function like
> 
> function errorListener() { ++errors; }
> 
> and then use that like
> 
> chrome.tabs.onCreated.addListener(errorListener);
> chrome.tabs.onRemoved.addListener(errorListener);
> chrome.tabs.onUpdated.addListener(errorListener);

Done.

https://codereview.chromium.org/1239643004/diff/300001/chrome/test/data/exten...
chrome/test/data/extensions/api_test/tabs/no_events/test.js:9:
chrome.test.assertTrue(false);
On 2015/07/20 21:29:18, kalman wrote:
> chrome.test.fail() would be more straightforward.
> 
> but that said, since you're failing the test in the chrome.test.sendMessage()
> response if errors > 0, you don't need these calls to fail(). Better to
> centralise.

Done.

[llandwerlin-old, 2015-07-21 11:17:52]

The CQ bit was checked by lionel.g.landwerlin@intel.com

[llandwerlin-old, 2015-07-21 11:17:53]

The patchset sent to the CQ was uploaded after l-g-t-m from kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/1239643004/#ps320001
(title: "nits")

[commit-bot: I haz the power, 2015-07-21 11:18:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1239643004/320001

[llandwerlin-old, 2015-07-21 13:10:05]

The CQ bit was unchecked by lionel.g.landwerlin@intel.com

[llandwerlin-old, 2015-07-21 13:10:36]

The CQ bit was checked by lionel.g.landwerlin@intel.com

[commit-bot: I haz the power, 2015-07-21 13:10:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1239643004/320001

[commit-bot: I haz the power, 2015-07-21 14:17:30]

Committed patchset #17 (id:320001)

[commit-bot: I haz the power, 2015-07-21 14:18:42]

Patchset 17 (id:??) landed as
https://crrev.com/d2315f72405e4776861fa79919a0051538660656
Cr-Commit-Position: refs/heads/master@{#339647}