Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Side by Side Diff: chrome/browser/extensions/extension_tab_util.h

Issue 1239643004: extensions: tabs: set tab id to -1 for app/devtools windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add test chrome.tabs events Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_TAB_UTIL_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_TAB_UTIL_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_TAB_UTIL_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_TAB_UTIL_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
(...skipping 159 matching lines...) Expand 10 before | Expand all | Expand 10 after
170 static void ForEachTab( 170 static void ForEachTab(
171 const base::Callback<void(content::WebContents*)>& callback); 171 const base::Callback<void(content::WebContents*)>& callback);
172 172
173 static WindowController* GetWindowControllerOfTab( 173 static WindowController* GetWindowControllerOfTab(
174 const content::WebContents* web_contents); 174 const content::WebContents* web_contents);
175 175
176 // Open the extension's options page. Returns true if an options page was 176 // Open the extension's options page. Returns true if an options page was
177 // successfully opened (though it may not necessarily *load*, e.g. if the 177 // successfully opened (though it may not necessarily *load*, e.g. if the
178 // URL does not exist). 178 // URL does not exist).
179 static bool OpenOptionsPage(const Extension* extension, Browser* browser); 179 static bool OpenOptionsPage(const Extension* extension, Browser* browser);
180
181 // Returns true if the given Browser can report tabs to extensions.
182 // Will return false for a devtools browser.
not at google - send to devlin 2015/07/20 21:29:18 I'd replace the second like with: "Example of Brow
llandwerlin-old 2015/07/21 09:45:41 Done.
183 static bool BrowserSupportsTabs(Browser* browser);
180 }; 184 };
181 185
182 } // namespace extensions 186 } // namespace extensions
183 187
184 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_TAB_UTIL_H_ 188 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_TAB_UTIL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698