extensions: tabs: set tab id to -1 for app/devtools windows

chrome/browser/extensions/api/tabs/tabs_event_router.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/tabs/tabs_event_router.h"
 
 #include "base/command_line.h"
 #include "base/json/json_writer.h"
 #include "base/values.h"
 #include "chrome/browser/chrome_notification_types.h"
@@ skipping 111 matching lines @@
 
   BrowserList::AddObserver(this);
 
   // Init() can happen after the browser is running, so catch up with any
   // windows that already exist.
   for (chrome::BrowserIterator it; !it.done(); it.Next()) {
     RegisterForBrowserNotifications(*it);
 
     // Also catch up our internal bookkeeping of tab entries.
     Browser* browser = *it;
-    if (browser->tab_strip_model()) {
+    if (!browser->is_devtools() && browser->tab_strip_model()) {

[not at google - send to devlin, 2015/07/16 17:09:23]

For whatever reason, this condition would make more sense to me if it checked
the tab_strip_model first. if (browser->tab_strip_model() &&
!browser->is_devtools()) { ... }

[llandwerlin-old, 2015/07/17 11:32:04]

Done.

       for (int i = 0; i < browser->tab_strip_model()->count(); ++i) {
         WebContents* contents = browser->tab_strip_model()->GetWebContentsAt(i);
         int tab_id = ExtensionTabUtil::GetTabId(contents);
         tab_entries_[tab_id] = make_linked_ptr(new TabEntry(contents));
       }
     }
   }
 }
 
 TabsEventRouter::~TabsEventRouter() {
   BrowserList::RemoveObserver(this);
 }
 
 void TabsEventRouter::OnBrowserAdded(Browser* browser) {
   RegisterForBrowserNotifications(browser);
 }
 
 void TabsEventRouter::RegisterForBrowserNotifications(Browser* browser) {
-  if (!profile_->IsSameProfile(browser->profile()))
+  if (!profile_->IsSameProfile(browser->profile()) || browser->is_devtools())
     return;
   // Start listening to TabStripModel events for this browser.
   TabStripModel* tab_strip = browser->tab_strip_model();
   tab_strip->AddObserver(this);
 
   for (int i = 0; i < tab_strip->count(); ++i) {
     RegisterForTabNotifications(tab_strip->GetWebContentsAt(i));
   }
 }
 
@@ skipping 467 matching lines @@
 void TabsEventRouter::OnFaviconUpdated(favicon::FaviconDriver* favicon_driver,
                                        bool icon_url_changed) {
   if (icon_url_changed) {
     favicon::ContentFaviconDriver* content_favicon_driver =
         static_cast<favicon::ContentFaviconDriver*>(favicon_driver);
     FaviconUrlUpdated(content_favicon_driver->web_contents());
   }
 }
 
 }  // namespace extensions