chrome/common/extensions/api/tabs.json - Issue 1239643004: extensions: tabs: set tab id to -1 for app/devtools windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/api/tabs.json

Issue 1239643004: extensions: tabs: set tab id to -1 for app/devtools windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_tab_util.cc ('k') | chrome/test/data/extensions/api_test/tabs/no_events/background.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/api/tabs.json

diff --git a/chrome/common/extensions/api/tabs.json b/chrome/common/extensions/api/tabs.json

index defeb1c09180bcef5ace2fbabd89a885b0eee93f..118f91f0d5d504a9271579063dacdc7058e8a870 100644

--- a/chrome/common/extensions/api/tabs.json

+++ b/chrome/common/extensions/api/tabs.json

@@ -11,7 +11,7 @@

"id": "Tab",

"type": "object",

"properties": {

- "id": {"type": "integer", "minimum": 0, "optional": true, "description": "The ID of the tab. Tab IDs are unique within a browser session. Under some circumstances a Tab may not be assigned an ID, for example when querying foreign tabs using the $(ref:sessions) API, in which case a session ID may be present."},

+ "id": {"type": "integer", "minimum": -1, "optional": true, "description": "The ID of the tab. Tab IDs are unique within a browser session. Under some circumstances a Tab may not be assigned an ID, for example when querying foreign tabs using the $(ref:sessions) API, in which case a session ID may be present. Tab ID can also be set to chrome.tabs.TAB_ID_NONE for apps and devtools windows."},

// TODO(kalman): Investigate how this is ending up as -1 (based on window type? a bug?) and whether it should be optional instead.

"index": {"type": "integer", "minimum": -1, "description": "The zero-based index of the tab within its window."},

"windowId": {"type": "integer", "minimum": 0, "description": "The ID of the window the tab is contained within."},

@@ -102,6 +102,12 @@

"description": "The type of window."

}

+ "properties": {

+ "TAB_ID_NONE": {

+ "value": -1,

+ "description": "An ID which represents the absence of a browser tab."

+ }

+ },

"functions": [

{

"name": "get",