extensions: tabs: set tab id to -1 for app/devtools windows

chrome/browser/extensions/api/sessions/sessions_apitest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/sessions/sessions_api.h"
 
 #include "base/command_line.h"
 #include "base/path_service.h"
 #include "base/strings/pattern.h"
 #include "base/strings/stringprintf.h"
@@ skipping 235 matching lines @@
     EXPECT_TRUE(sessions->GetDictionary(0, &session));
     const base::DictionaryValue* window = NULL;
     EXPECT_TRUE(session->GetDictionary("window", &window));
     // Only the tabs are interesting.
     const base::ListValue* tabs = NULL;
     EXPECT_TRUE(window->GetList("tabs", &tabs));
     EXPECT_EQ(arraysize(kTabIDs), tabs->GetSize());
     for (size_t j = 0; j < tabs->GetSize(); ++j) {
       const base::DictionaryValue* tab = NULL;
       EXPECT_TRUE(tabs->GetDictionary(j, &tab));
-      EXPECT_FALSE(tab->HasKey("id"));  // sessions API does not give tab IDs
+      EXPECT_EQ(api_test_utils::GetInteger(tab, "id"),
+                -1);  // sessions API does not give tab IDs

[not at google - send to devlin, 2015/07/16 17:09:23]

I'd like to keep using the lack of a tab ID as meaning it's a session API.
Pragmatically, we shouldn't be changing APIs. Philosophically, we could say that
-1 means "there is no tab ID" whereas the lack of a tab ID means "there is a tab
ID, but we don't know it". Not that interesting a distinction to make, but
that's where we are.

[llandwerlin-old, 2015/07/17 11:32:04]

Done.

       EXPECT_EQ(static_cast<int>(j), api_test_utils::GetInteger(tab, "index"));
       EXPECT_EQ(0, api_test_utils::GetInteger(tab, "windowId"));
       // Test setup code always sets tab 0 to selected (which means active in
       // extension terminology).
       EXPECT_EQ(j == 0, api_test_utils::GetBoolean(tab, "active"));
       // While selected/highlighted are different to active, and should always
       // be false.
       EXPECT_FALSE(api_test_utils::GetBoolean(tab, "selected"));
       EXPECT_FALSE(api_test_utils::GetBoolean(tab, "highlighted"));
       EXPECT_FALSE(api_test_utils::GetBoolean(tab, "incognito"));
@@ skipping 117 matching lines @@
     return;
 #endif
 
   ASSERT_TRUE(RunExtensionSubtest("sessions",
                                   "sessions.html")) << message_;
 }
 
 }  // namespace
 
 }  // namespace extensions