blink: permissions: add plumbing to request permissions

blink: permissions: add plumbing to request permissions

This is part of a three sided change:
https://codereview.chromium.org/1236003004 (this)
https://codereview.chromium.org/1240783002
https://codereview.chromium.org/1248703002

BUG=510405
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199810

[dgrogan, 2015-07-16 19:21:46]

dgrogan@chromium.org changed reviewers:
+ dgrogan@chromium.org

[dgrogan, 2015-07-16 19:21:46]

I don't want to distract you from working on this but do you have any idea when
it will land?

I hacked together something similar in
https://codereview.chromium.org/1154573005/diff/300001/public/platform/module...
and
https://codereview.chromium.org/1164073005/diff/420001/content/child/permissi...

but I'd rather use your legit version once it lands.

[Lalit Maganti, 2015-07-16 19:58:49]

On 2015/07/16 at 19:21:46, dgrogan wrote:
> I don't want to distract you from working on this but do you have any idea
when it will land?
> 
> I hacked together something similar in
https://codereview.chromium.org/1154573005/diff/300001/public/platform/module...
and
https://codereview.chromium.org/1164073005/diff/420001/content/child/permissi...
> 
> but I'd rather use your legit version once it lands.

I'm hoping it will land by middle of next week. The code itself here should work
fine - if you apply this CL and use it for durable storage it should work.
However there are a few things which I need to finish before this lands
1. Revoke needs to land since this depends on that - I could break the
dependency if you urgently need this patch though.
2. Need to investigate some issue in the permission test framework which is
breaking midi tests for revoke. It will break the midi test for request too.
3. Need to write tests for request.
I'm hoping I can finish 2 tomorrow and then get a start on review cycle by
Monday afternoon having done 3 Monday morning.

[dgrogan, 2015-07-16 21:44:14]

Middle of next week would be fine. No need to break the dependency if that will
be some annoying work.

If it goes much longer than that I'll be in touch though :)

[Lalit Maganti, 2015-07-21 13:54:06]

lalitm@google.com changed reviewers:
+ mlamouri@chromium.org

[mlamouri (slow - plz ping), 2015-07-24 14:22:34]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2015-07-24 14:22:34]

lgtm

[commit-bot: I haz the power, 2015-07-24 14:22:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1236003004/130001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1236003004/130001

[commit-bot: I haz the power, 2015-07-24 14:28:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-24 14:28:25]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/3...)

[Lalit Maganti, 2015-07-24 14:33:54]

lalitm@google.com changed reviewers:
+ mkwst@chromium.org

[Lalit Maganti, 2015-07-24 14:33:55]

mkwst: could you please review the UseCounter change?

[dgrogan, 2015-07-29 02:46:24]

Is this blocking https://codereview.chromium.org/1240783002 ? A quick glance
suggests that you could land that without this but maybe I'm missing something.

[Lalit Maganti, 2015-07-30 10:01:32]

mkwst: just a ping on the UseCounter change - since this is blocking both the
Chromium patches as well as other patches it would be good to land this as soon
as possible
dgrogan: No strictly it's not blocking but that's just because we don't have the
override keyword on the methods in that patch. I will make a new CL to add those
in at a later date. I would still like this landed before the other one though.

[dgrogan, 2015-07-30 14:01:05]

Looks like mkwst is OOO today. You should probably pick someone from this list
anyway instead. Unless mkwst was specifically suggested by someone (I am not
familiar with UseCounter changes)

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

[Lalit Maganti, 2015-07-30 14:06:48]

lalitm@google.com changed reviewers:
+ bokan@chromium.org

[Lalit Maganti, 2015-07-30 14:06:48]

dgrogan: I see. I've added bokan for review for UseCounter then.
bokan: could you please review the UseCounter change?

[bokan, 2015-07-30 22:37:58]

lgtm but I'm not too familiar with UseCounters so if you're not terribly
confident I'd get someone else to double check.

https://codereview.chromium.org/1236003004/diff/170001/Source/core/frame/UseC...
File Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/1236003004/diff/170001/Source/core/frame/UseC...
Source/core/frame/UseCounter.h:810: V8Permissions_Request_Method = 915,
This gets used in an autogenerated V8 method, correct?

[Mike West, 2015-07-31 07:16:13]

lgtm

[Lalit Maganti, 2015-07-31 08:29:48]

https://codereview.chromium.org/1236003004/diff/170001/Source/core/frame/UseC...
File Source/core/frame/UseCounter.h (right):

https://codereview.chromium.org/1236003004/diff/170001/Source/core/frame/UseC...
Source/core/frame/UseCounter.h:810: V8Permissions_Request_Method = 915,
On 2015/07/30 at 22:37:58, bokan wrote:
> This gets used in an autogenerated V8 method, correct?

This is used in histograms on the Chrome side.

[Lalit Maganti, 2015-07-31 08:29:50]

The CQ bit was checked by lalitm@google.com

[Lalit Maganti, 2015-07-31 08:29:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/1236003004/#ps170001
(title: "Rebase")

[commit-bot: I haz the power, 2015-07-31 08:30:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1236003004/170001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1236003004/170001

[commit-bot: I haz the power, 2015-07-31 09:50:43]

Committed patchset #10 (id:170001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199810