blink: permissions: add tests for request

blink: permissions: add tests for request

This is part of a three sided change:
https://codereview.chromium.org/1236003004
https://codereview.chromium.org/1240783002
https://codereview.chromium.org/1248703002 (this)

BUG=510405
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199820

[Lalit Maganti, 2015-07-21 15:26:38]

lalitm@google.com changed reviewers:
+ mlamouri@chromium.org

[mlamouri (slow - plz ping), 2015-07-24 14:31:13]

lgtm with comments applied.

https://codereview.chromium.org/1248703002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/permissions/chromium/resources/test-request.js
(right):

https://codereview.chromium.org/1248703002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/permissions/chromium/resources/test-request.js:18:
callback();
Can you call throw and pass the message then at the end of the promise chain,
you can have a .catch() that will grab the exception, show the message passed to
it and call callback().

https://codereview.chromium.org/1248703002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/permissions/chromium/resources/test-request.js:34: test:
async_test('Test geolocation permission in ' + get_current_scope() + ' scope.'),
'Test basic request behaviour in [...]

And add a comment explaining why this test only:
// request() is expected to show a UI then return the new permission status.
// In layout tests no UI is shown so it boils down to returning the permission
// status. The tests only check that behaviour given that trying to simulate
// user decision would simply test the test infrastructure.

https://codereview.chromium.org/1248703002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/permissions/chromium/test-request-sharedworker.html
(right):

https://codereview.chromium.org/1248703002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/permissions/chromium/test-request-sharedworker.html:13:
// Run the tests on the SharedWorker scope.
nit: no need for that comment

https://codereview.chromium.org/1248703002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/permissions/chromium/test-request-window.html
(right):

https://codereview.chromium.org/1248703002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/permissions/chromium/test-request-window.html:13: // Run
the tests on the Window scope.
ditto

https://codereview.chromium.org/1248703002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/permissions/chromium/test-request-worker.html
(right):

https://codereview.chromium.org/1248703002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/permissions/chromium/test-request-worker.html:13: // Run
the tests on the SharedWorker scope.
ditto

[Lalit Maganti, 2015-07-30 10:10:15]

https://codereview.chromium.org/1248703002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/permissions/chromium/resources/test-request.js
(right):

https://codereview.chromium.org/1248703002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/permissions/chromium/resources/test-request.js:18:
callback();
On 2015/07/24 at 14:31:12, Mounir Lamouri OOO up to 3 Aug wrote:
> Can you call throw and pass the message then at the end of the promise chain,
you can have a .catch() that will grab the exception, show the message passed to
it and call callback().

Done.

https://codereview.chromium.org/1248703002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/permissions/chromium/resources/test-request.js:34: test:
async_test('Test geolocation permission in ' + get_current_scope() + ' scope.'),
On 2015/07/24 at 14:31:12, Mounir Lamouri OOO up to 3 Aug wrote:
> 'Test basic request behaviour in [...]
> 
> And add a comment explaining why this test only:
> // request() is expected to show a UI then return the new permission status.
> // In layout tests no UI is shown so it boils down to returning the permission
> // status. The tests only check that behaviour given that trying to simulate
> // user decision would simply test the test infrastructure.

Done.

https://codereview.chromium.org/1248703002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/permissions/chromium/test-request-sharedworker.html
(right):

https://codereview.chromium.org/1248703002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/permissions/chromium/test-request-sharedworker.html:13:
// Run the tests on the SharedWorker scope.
On 2015/07/24 at 14:31:12, Mounir Lamouri OOO up to 3 Aug wrote:
> nit: no need for that comment

Done.

https://codereview.chromium.org/1248703002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/permissions/chromium/test-request-window.html
(right):

https://codereview.chromium.org/1248703002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/permissions/chromium/test-request-window.html:13: // Run
the tests on the Window scope.
On 2015/07/24 at 14:31:12, Mounir Lamouri OOO up to 3 Aug wrote:
> ditto

Done.

https://codereview.chromium.org/1248703002/diff/40001/LayoutTests/http/tests/...
File LayoutTests/http/tests/permissions/chromium/test-request-worker.html
(right):

https://codereview.chromium.org/1248703002/diff/40001/LayoutTests/http/tests/...
LayoutTests/http/tests/permissions/chromium/test-request-worker.html:13: // Run
the tests on the SharedWorker scope.
On 2015/07/24 at 14:31:12, Mounir Lamouri OOO up to 3 Aug wrote:
> ditto

Done.

[Lalit Maganti, 2015-07-31 10:54:35]

The CQ bit was checked by lalitm@google.com

[Lalit Maganti, 2015-07-31 10:54:35]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlamouri@chromium.org
Link to the patchset: https://codereview.chromium.org/1248703002/#ps80001
(title: "Fix comments")

[commit-bot: I haz the power, 2015-07-31 10:54:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1248703002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1248703002/80001

[commit-bot: I haz the power, 2015-07-31 12:16:51]

Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199820