Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 1240783002: content: permissions: add plumbing to request permissions (Closed)

Created:
5 years, 5 months ago by Lalit Maganti
Modified:
5 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, dgrogan, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@permissions-content-blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: permissions: add plumbing to request permissions This is part of a three sided change: https://codereview.chromium.org/1236003004 https://codereview.chromium.org/1240783002 (this) https://codereview.chromium.org/1248703002 BUG=510405 Committed: https://crrev.com/3d05e9ae66ac77cef754bbdd26757e1d97f0b449 Cr-Commit-Position: refs/heads/master@{#341311}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -0 lines) Patch
M content/child/permissions/permission_dispatcher.h View 1 3 chunks +11 lines, -0 lines 0 comments Download
M content/child/permissions/permission_dispatcher.cc View 1 4 chunks +37 lines, -0 lines 0 comments Download
M content/child/permissions/permission_dispatcher_thread_proxy.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/child/permissions/permission_dispatcher_thread_proxy.cc View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Lalit Maganti
5 years, 5 months ago (2015-07-21 15:27:22 UTC) #2
mlamouri (slow - plz ping)
lgtm
5 years, 5 months ago (2015-07-24 14:24:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240783002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1240783002/20001
5 years, 5 months ago (2015-07-24 14:27:01 UTC) #6
dgrogan
Looks like fixing this should be easy, it's just WebPermissionQueryCallback rename.
5 years, 5 months ago (2015-07-24 16:37:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1240783002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1240783002/60001
5 years, 4 months ago (2015-07-31 10:33:50 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 4 months ago (2015-07-31 10:53:53 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-07-31 10:54:26 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3d05e9ae66ac77cef754bbdd26757e1d97f0b449
Cr-Commit-Position: refs/heads/master@{#341311}

Powered by Google App Engine
This is Rietveld 408576698