Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 12334073: Remove WebContents methods that duplicate WebContentsView methods. (Closed)

Created:
7 years, 10 months ago by jam
Modified:
7 years, 10 months ago
Reviewers:
scottmg
CC:
chromium-reviews, asanka, David Black, jam, sadrul, nkostylev+watch_chromium.org, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, gideonwald, dcheng, Dmitry Titov, davemoore+watch_chromium.org, Albert Bodenhamer, kinuko+watch, stevenjb+watch_chromium.org, joi+watch-content_chromium.org, melevin, vsevik, Aaron Boodman, benquan, Ilya Sherman, kkania, dbeam+watch-autofill_chromium.org, dominich, sail+watch_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, tzik+watch_chromium.org, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, jennb, dyu1, Randy Smith (Not in Mondays), jianli, samarth+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, Raman Kakilate, Jered, tfarina, ben+watch_chromium.org, sreeram, yurys, benjhayden+dwatch_chromium.org, robertshield, Dane Wallinga, rdsmith+dwatch_chromium.org, estade+watch_chromium.org, pfeldman
Visibility:
Public.

Description

Remove WebContents methods that duplicate WebContentsView methods. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=184598

Patch Set 1 #

Patch Set 2 : fix print preview focus test by turning it into an interactive browser test (and sync) #

Patch Set 3 : sync again #

Patch Set 4 : #

Patch Set 5 : cros fix #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+360 lines, -289 lines) Patch
M android_webview/native/aw_web_contents_view_delegate.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/autofill/autofill_external_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/risk/fingerprint_browsertest.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/automation/automation_provider_win.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/webui_login_display_host.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_login_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/devtools/devtools_window.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/download/download_file_picker.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/download/download_shelf.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/download/save_package_file_picker.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/download/save_package_file_picker_chromeos.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/developer_private/entry_picker.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/instant/instant_controller.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/managed_mode/managed_mode_navigation_observer.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller.h View 1 3 chunks +11 lines, -1 line 0 comments Download
M chrome/browser/printing/print_preview_dialog_controller.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/speech/speech_recognition_bubble.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/constrained_web_dialog_delegate_mac.mm View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/constrained_window/constrained_window_mac_browsertest.mm View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/dev_tools_controller.mm View 3 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_started_animation_mac.mm View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/native_app_window_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/find_bar/find_bar_cocoa_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/infobars/extension_infobar_controller.mm View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/notifications/balloon_view_host_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller.mm View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/previewable_contents_controller_browsertest.mm View 4 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/tabpose_window.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/web_dialog_window_controller.mm View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/constrained_web_dialog_delegate_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/download/download_started_animation_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/native_app_window_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/find_bar_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/gtk_window_util.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/notifications/balloon_view_host_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/panels/panel_gtk.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/password_generation_bubble_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/speech_recognition_bubble_gtk.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/tab_contents_container_gtk.cc View 1 2 7 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/tabs/dragged_tab_controller_gtk.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/color_chooser_aura.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/constrained_window_views.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/download/download_started_animation_views.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/dropdown_bar_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_dialog.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_popup.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/native_app_window_views.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/external_protocol_dialog.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/external_tab_container_win.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/find_bar_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/hung_renderer_view.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/speech_recognition_bubble_views.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_drag_controller.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/downloads_dom_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/foreign_session_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/ntp/recently_closed_tabs_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 4 chunks +7 lines, -6 lines 0 comments Download
A chrome/browser/ui/webui/print_preview/print_preview_ui_interactive_browsertest.cc View 1 1 chunk +97 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_ui_unittest.cc View 1 2 chunks +0 lines, -39 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/gpu/gpu_pixel_browsertest.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/perf/rendering/throughput_tests.cc View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M components/web_contents_delegate_android/color_chooser_android.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/android/download_controller_android_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_drag_win.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 4 chunks +3 lines, -19 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura_browsertest.cc View 5 chunks +6 lines, -4 lines 0 comments Download
M content/public/browser/web_contents.h View 1 chunk +0 lines, -16 lines 0 comments Download
M content/public/test/web_contents_tester.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M content/public/test/web_contents_tester.cc View 1 2 chunks +0 lines, -28 lines 0 comments Download
M content/shell/shell.cc View 1 2 chunks +5 lines, -5 lines 0 comments Download
M content/shell/shell_aura.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M content/shell/shell_devtools_frontend.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M content/shell/shell_download_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/shell/shell_gtk.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M content/shell/shell_web_contents_view_delegate_gtk.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M content/shell/shell_web_contents_view_delegate_mac.mm View 1 2 chunks +4 lines, -4 lines 0 comments Download
M content/shell/shell_web_contents_view_delegate_win.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/controls/webview/webview.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M ui/views/examples/webview_example.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
7 years, 10 months ago (2013-02-25 18:11:01 UTC) #1
scottmg
lgtm
7 years, 10 months ago (2013-02-25 18:30:51 UTC) #2
jam
btw I updated the patch to fix the print preview unittest compile problem. Now that ...
7 years, 10 months ago (2013-02-26 02:03:38 UTC) #3
scottmg
7 years, 10 months ago (2013-02-26 02:11:43 UTC) #4
On 2013/02/26 02:03:38, jam wrote:
> btw I updated the patch to fix the print preview unittest compile problem. Now
> that Focus() isn't on WebContents, it's awkward to override a bunch of classes
> just to get this notification.
> 
> Instead, I cleaned up this use of WebContentsTester. The test was really
> checking that focus is set correctly, so I turned it into an interactive test.

ok, still lg

Powered by Google App Engine
This is Rietveld 408576698