chrome/browser/ui/views/extensions/extension_dialog.cc - Issue 12334073: Remove WebContents methods that duplicate WebContentsView methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_dialog.cc

Issue 12334073: Remove WebContents methods that duplicate WebContentsView methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/extensions/extension_dialog.cc

diff --git a/chrome/browser/ui/views/extensions/extension_dialog.cc b/chrome/browser/ui/views/extensions/extension_dialog.cc

index 5571cbb04e13abaf427832d136b8d078660f6af7..d8b74ae02e5637027142a2f7bee71ef526967e7d 100644

--- a/chrome/browser/ui/views/extensions/extension_dialog.cc

+++ b/chrome/browser/ui/views/extensions/extension_dialog.cc

@@ -16,6 +16,7 @@

#include "content/public/browser/render_view_host.h"

#include "content/public/browser/render_widget_host_view.h"

#include "content/public/browser/web_contents.h"

+#include "content/public/browser/web_contents_view.h"

#include "googleurl/src/gurl.h"

#include "ui/gfx/screen.h"

#include "ui/views/background.h"

@@ -109,7 +110,7 @@ ExtensionDialog* ExtensionDialog::ShowInternal(

host->view()->SetVisible(true);

// Ensure the DOM JavaScript can respond immediately to keyboard shortcuts.

- host->host_contents()->Focus();

+ host->host_contents()->GetView()->Focus();

return dialog;

}