Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: chrome/browser/ui/views/external_protocol_dialog.cc

Issue 12334073: Remove WebContents methods that duplicate WebContentsView methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/external_protocol_dialog.h" 5 #include "chrome/browser/ui/views/external_protocol_dialog.h"
6 6
7 #include "base/metrics/histogram.h" 7 #include "base/metrics/histogram.h"
8 #include "base/string_util.h" 8 #include "base/string_util.h"
9 #include "base/threading/thread.h" 9 #include "base/threading/thread.h"
10 #include "base/threading/thread_restrictions.h" 10 #include "base/threading/thread_restrictions.h"
11 #include "base/utf_string_conversions.h" 11 #include "base/utf_string_conversions.h"
12 #include "base/win/registry.h" 12 #include "base/win/registry.h"
13 #include "chrome/browser/external_protocol/external_protocol_handler.h" 13 #include "chrome/browser/external_protocol/external_protocol_handler.h"
14 #include "chrome/browser/tab_contents/tab_util.h" 14 #include "chrome/browser/tab_contents/tab_util.h"
15 #include "content/public/browser/web_contents.h" 15 #include "content/public/browser/web_contents.h"
16 #include "content/public/browser/web_contents_view.h"
16 #include "grit/chromium_strings.h" 17 #include "grit/chromium_strings.h"
17 #include "grit/generated_resources.h" 18 #include "grit/generated_resources.h"
18 #include "ui/base/l10n/l10n_util.h" 19 #include "ui/base/l10n/l10n_util.h"
19 #include "ui/base/text/text_elider.h" 20 #include "ui/base/text/text_elider.h"
20 #include "ui/views/controls/message_box_view.h" 21 #include "ui/views/controls/message_box_view.h"
21 #include "ui/views/widget/widget.h" 22 #include "ui/views/widget/widget.h"
22 23
23 using content::WebContents; 24 using content::WebContents;
24 25
25 namespace { 26 namespace {
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
148 message_text += l10n_util::GetStringUTF16(IDS_EXTERNAL_PROTOCOL_WARNING); 149 message_text += l10n_util::GetStringUTF16(IDS_EXTERNAL_PROTOCOL_WARNING);
149 150
150 views::MessageBoxView::InitParams params(message_text); 151 views::MessageBoxView::InitParams params(message_text);
151 params.message_width = kMessageWidth; 152 params.message_width = kMessageWidth;
152 message_box_view_ = new views::MessageBoxView(params); 153 message_box_view_ = new views::MessageBoxView(params);
153 message_box_view_->SetCheckBoxLabel( 154 message_box_view_->SetCheckBoxLabel(
154 l10n_util::GetStringUTF16(IDS_EXTERNAL_PROTOCOL_CHECKBOX_TEXT)); 155 l10n_util::GetStringUTF16(IDS_EXTERNAL_PROTOCOL_CHECKBOX_TEXT));
155 156
156 HWND root_hwnd; 157 HWND root_hwnd;
157 if (web_contents_) { 158 if (web_contents_) {
158 root_hwnd = GetAncestor(web_contents_->GetContentNativeView(), GA_ROOT); 159 root_hwnd = GetAncestor(web_contents_->GetView()->GetContentNativeView(),
160 GA_ROOT);
159 } else { 161 } else {
160 // Dialog is top level if we don't have a web_contents associated with us. 162 // Dialog is top level if we don't have a web_contents associated with us.
161 root_hwnd = NULL; 163 root_hwnd = NULL;
162 } 164 }
163 165
164 views::Widget::CreateWindowWithParent(this, root_hwnd)->Show(); 166 views::Widget::CreateWindowWithParent(this, root_hwnd)->Show();
165 } 167 }
166 168
167 // static 169 // static
168 std::wstring ExternalProtocolDialog::GetApplicationForProtocol( 170 std::wstring ExternalProtocolDialog::GetApplicationForProtocol(
(...skipping 12 matching lines...) Expand all
181 std::wstring parameters = url_spec.substr(split_offset + 1, 183 std::wstring parameters = url_spec.substr(split_offset + 1,
182 url_spec.length() - 1); 184 url_spec.length() - 1);
183 std::wstring application_to_launch; 185 std::wstring application_to_launch;
184 if (cmd_key.ReadValue(NULL, &application_to_launch) == ERROR_SUCCESS) { 186 if (cmd_key.ReadValue(NULL, &application_to_launch) == ERROR_SUCCESS) {
185 ReplaceSubstringsAfterOffset(&application_to_launch, 0, L"%1", parameters); 187 ReplaceSubstringsAfterOffset(&application_to_launch, 0, L"%1", parameters);
186 return application_to_launch; 188 return application_to_launch;
187 } else { 189 } else {
188 return std::wstring(); 190 return std::wstring();
189 } 191 }
190 } 192 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/extensions/native_app_window_views.cc ('k') | chrome/browser/ui/views/external_tab_container_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698