chrome/browser/ui/views/extensions/extension_popup.cc - Issue 12334073: Remove WebContents methods that duplicate WebContentsView methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_popup.cc

Issue 12334073: Remove WebContents methods that duplicate WebContentsView methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/extensions/extension_popup.cc

diff --git a/chrome/browser/ui/views/extensions/extension_popup.cc b/chrome/browser/ui/views/extensions/extension_popup.cc

index c5eca5580d56dd5ef717f8ac90ddb74d69ad4d97..259d714306136d846ae361444d66782edb0e4f89 100644

--- a/chrome/browser/ui/views/extensions/extension_popup.cc

+++ b/chrome/browser/ui/views/extensions/extension_popup.cc

@@ -18,6 +18,7 @@

#include "content/public/browser/notification_source.h"

#include "content/public/browser/render_view_host.h"

#include "content/public/browser/web_contents.h"

+#include "content/public/browser/web_contents_view.h"

#include "ui/gfx/insets.h"

#include "ui/views/layout/fill_layout.h"

#include "ui/views/widget/widget.h"

@@ -210,7 +211,7 @@ void ExtensionPopup::ShowBubble() {

host()->view()->RequestFocus();

// Focus on the host contents when the bubble is first shown.

- host()->host_contents()->Focus();

+ host()->host_contents()->GetView()->Focus();

// Listen for widget focus changes after showing (used for non-aura win).

views::WidgetFocusManager::GetInstance()->AddFocusChangeListener(this);