chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc - Issue 12334073: Remove WebContents methods that duplicate WebContentsView methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

Issue 12334073: Remove WebContents methods that duplicate WebContentsView methods. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/download/save_package_file_picker_chromeos.cc ('k') | chrome/browser/extensions/api/developer_private/entry_picker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

diff --git a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

index 4224050407f1b7d0cbbccc08a4f38cdcab348ca2..71ad989951b8962c92cac3b19497f9e111bfc430 100644

--- a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

+++ b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc

@@ -26,6 +26,7 @@

#include "chrome/common/pref_names.h"

#include "content/public/browser/render_view_host.h"

#include "content/public/browser/web_contents.h"

+#include "content/public/browser/web_contents_view.h"

#include "content/public/browser/web_ui.h"

#include "grit/generated_resources.h"

#include "ui/base/l10n/l10n_util.h"

@@ -404,7 +405,7 @@ bool BookmarkManagerPrivateStartDragFunction::RunImpl() {

dispatcher()->delegate()->GetAssociatedWebContents();

CHECK(web_contents);

bookmark_utils::DragBookmarks(profile(), nodes,

- web_contents->GetNativeView());

+ web_contents->GetView()->GetNativeView());

return true;

} else {